Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(375)

Issue 1546323004: Force clang/tot bots to do clobber builds of clang for a bit. (Closed)

Created:
4 years, 12 months ago by Nico
Modified:
4 years, 12 months ago
Reviewers:
hans
CC:
chromium-reviews, yunlian, eugenis+clang_chromium.org, glider+clang_chromium.org, dmikurube+clang_chromium.org, ukai+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Force clang/tot bots to do clobber builds of clang for a bit. Apparently cmake doesn't like it if the compiler changes like it did in https://codereview.chromium.org/1555443002/ without a clobber build. Since this might help with issue 569337 too (who knows), do it everywhere for a short while instead of just on linux. BUG=509739, 569337 TBR=hans Committed: https://chromium.googlesource.com/chromium/src/+/1c0fd1fac8ee649f5da00473e5d88565ea3ae930

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M tools/clang/scripts/update.py View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
Nico
4 years, 12 months ago (2015-12-29 00:19:57 UTC) #2
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/1c0fd1fac8ee649f5da00473e5d88565ea3ae930 Cr-Commit-Position: refs/heads/master@{#367029}
4 years, 12 months ago (2015-12-29 00:21:52 UTC) #5
Nico
Committed patchset #1 (id:1) manually as 1c0fd1fac8ee649f5da00473e5d88565ea3ae930 (presubmit successful).
4 years, 12 months ago (2015-12-29 00:22:31 UTC) #7
hans
lgtm
4 years, 12 months ago (2015-12-29 09:00:20 UTC) #8
Nico
4 years, 11 months ago (2015-12-29 14:25:20 UTC) #9
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1554573002/ by thakis@chromium.org.

The reason for reverting is: Every tot bot should have cycled with this by now..

Powered by Google App Engine
This is Rietveld 408576698