Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(196)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1546323002: [ic] Fixed receiver_map register trashing in KeyedStoreIC megamorphic. (Closed)

Created:
4 years, 12 months ago by Igor Sheludko
Modified:
4 years, 11 months ago
Reviewers:
Camillo Bruni, v8-ppc-ports
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[ic] Fixed receiver_map register trashing in KeyedStoreIC megamorphic. BUG=chromium:571370 LOG=Y Committed: https://crrev.com/c1aded3c4b49cc4ac2b185350a3cfa835e78ff27 Cr-Commit-Position: refs/heads/master@{#33057}

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+174 lines, -176 lines) Patch
M src/arm/macro-assembler-arm.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/ic/arm/ic-arm.cc View 7 chunks +25 lines, -27 lines 0 comments Download
M src/ic/mips/ic-mips.cc View 6 chunks +32 lines, -32 lines 0 comments Download
M src/ic/mips64/ic-mips64.cc View 6 chunks +31 lines, -32 lines 0 comments Download
M src/ic/ppc/ic-ppc.cc View 7 chunks +36 lines, -36 lines 0 comments Download
M src/mips/macro-assembler-mips.h View 1 chunk +5 lines, -8 lines 0 comments Download
M src/mips/macro-assembler-mips.cc View 4 chunks +12 lines, -12 lines 0 comments Download
M src/mips64/macro-assembler-mips64.h View 1 chunk +5 lines, -8 lines 0 comments Download
M src/mips64/macro-assembler-mips64.cc View 5 chunks +13 lines, -14 lines 0 comments Download
M src/ppc/macro-assembler-ppc.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/ppc/macro-assembler-ppc.cc View 3 chunks +7 lines, -2 lines 0 comments Download
A + test/mjsunit/regress/regress-crbug-571370.js View 1 chunk +5 lines, -4 lines 0 comments Download

Messages

Total messages: 16 (8 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1546323002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1546323002/1
4 years, 12 months ago (2015-12-28 14:52:52 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1546323002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1546323002/20001
4 years, 12 months ago (2015-12-28 16:02:18 UTC) #6
Igor Sheludko
PTAL
4 years, 12 months ago (2015-12-28 16:05:52 UTC) #8
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 12 months ago (2015-12-28 16:28:30 UTC) #10
Camillo Bruni
LGTM I wonder though in how many other helper methods we currently forget to check ...
4 years, 12 months ago (2015-12-29 09:43:39 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1546323002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1546323002/20001
4 years, 11 months ago (2015-12-29 12:50:24 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:20001)
4 years, 11 months ago (2015-12-29 12:51:56 UTC) #14
commit-bot: I haz the power
4 years, 11 months ago (2015-12-29 12:52:18 UTC) #16
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/c1aded3c4b49cc4ac2b185350a3cfa835e78ff27
Cr-Commit-Position: refs/heads/master@{#33057}

Powered by Google App Engine
This is Rietveld 408576698