Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1214)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1546253002: Include the host in PowerSaveBlockResourceThrottle. (Closed)

Created:
4 years, 12 months ago by Avi (use Gerrit)
Modified:
4 years, 12 months ago
Reviewers:
Lei Zhang
CC:
chromium-reviews, darin-cc_chromium.org, jam, loading-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Include the host in PowerSaveBlockResourceThrottle. This allows us to diagnose through system tools unexpected sleep prevention until a more proper UI solution (such as in bug http://crbug.com/571426) is implemented. BUG=571250 Committed: https://crrev.com/cd0ae84e034df519f003a6fd2b63af25c64dc84a Cr-Commit-Position: refs/heads/master@{#366945}

Patch Set 1 #

Total comments: 2

Patch Set 2 : oops #

Total comments: 2

Patch Set 3 : const #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -5 lines) Patch
M content/browser/loader/power_save_block_resource_throttle.h View 1 2 3 chunks +4 lines, -1 line 0 comments Download
M content/browser/loader/power_save_block_resource_throttle.cc View 2 chunks +4 lines, -3 lines 0 comments Download
M content/browser/loader/resource_dispatcher_host_impl.cc View 1 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 18 (7 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1546253002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1546253002/1
4 years, 12 months ago (2015-12-27 22:02:19 UTC) #2
Avi (use Gerrit)
At least when we do a "pmset -g assertions" we should get a vague idea ...
4 years, 12 months ago (2015-12-27 22:03:26 UTC) #4
dcheng
https://codereview.chromium.org/1546253002/diff/1/content/browser/loader/power_save_block_resource_throttle.h File content/browser/loader/power_save_block_resource_throttle.h (right): https://codereview.chromium.org/1546253002/diff/1/content/browser/loader/power_save_block_resource_throttle.h#newcode34 content/browser/loader/power_save_block_resource_throttle.h:34: std::string& host_; Drive-by: why reference? If someone passes a ...
4 years, 12 months ago (2015-12-27 22:05:29 UTC) #5
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: chromeos_daisy_chromium_compile_only_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_chromium_compile_only_ng/builds/74064)
4 years, 12 months ago (2015-12-27 22:10:31 UTC) #7
Avi (use Gerrit)
Thanks. https://codereview.chromium.org/1546253002/diff/1/content/browser/loader/power_save_block_resource_throttle.h File content/browser/loader/power_save_block_resource_throttle.h (right): https://codereview.chromium.org/1546253002/diff/1/content/browser/loader/power_save_block_resource_throttle.h#newcode34 content/browser/loader/power_save_block_resource_throttle.h:34: std::string& host_; On 2015/12/27 22:05:29, dcheng wrote: > ...
4 years, 12 months ago (2015-12-27 22:12:36 UTC) #9
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1546253002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1546253002/20001
4 years, 12 months ago (2015-12-27 22:12:37 UTC) #10
Lei Zhang
lgtm https://codereview.chromium.org/1546253002/diff/20001/content/browser/loader/power_save_block_resource_throttle.h File content/browser/loader/power_save_block_resource_throttle.h (right): https://codereview.chromium.org/1546253002/diff/20001/content/browser/loader/power_save_block_resource_throttle.h#newcode34 content/browser/loader/power_save_block_resource_throttle.h:34: std::string host_; const?
4 years, 12 months ago (2015-12-27 22:42:38 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1546253002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1546253002/40001
4 years, 12 months ago (2015-12-27 22:47:47 UTC) #14
Avi (use Gerrit)
https://codereview.chromium.org/1546253002/diff/20001/content/browser/loader/power_save_block_resource_throttle.h File content/browser/loader/power_save_block_resource_throttle.h (right): https://codereview.chromium.org/1546253002/diff/20001/content/browser/loader/power_save_block_resource_throttle.h#newcode34 content/browser/loader/power_save_block_resource_throttle.h:34: std::string host_; On 2015/12/27 22:42:38, Lei Zhang wrote: > ...
4 years, 12 months ago (2015-12-27 22:47:55 UTC) #15
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 12 months ago (2015-12-27 23:54:45 UTC) #16
commit-bot: I haz the power
4 years, 12 months ago (2015-12-27 23:55:38 UTC) #18
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/cd0ae84e034df519f003a6fd2b63af25c64dc84a
Cr-Commit-Position: refs/heads/master@{#366945}

Powered by Google App Engine
This is Rietveld 408576698