Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1546243002: Convert Pass()→std::move() in //storage (Closed)

Created:
4 years, 12 months ago by dcheng
Modified:
4 years, 12 months ago
CC:
chromium-reviews, kinuko+fileapi, nhiroki, tzik
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Convert Pass()→std::move() in //storage ❆(੭ु ◜◡‾)੭ु⁾☃❆ BUG=557422 R=avi@chromium.org TBR=kinuko@chromium.org Committed: https://crrev.com/dae49253c1c80ffbdab640902fc1a5142d611c1a Cr-Commit-Position: refs/heads/master@{#366944}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+143 lines, -151 lines) Patch
M storage/browser/blob/blob_data_builder.cc View 8 chunks +12 lines, -12 lines 0 comments Download
M storage/browser/blob/blob_data_handle.cc View 3 chunks +4 lines, -8 lines 0 comments Download
M storage/browser/blob/blob_data_item.cc View 1 chunk +8 lines, -9 lines 0 comments Download
M storage/browser/blob/blob_reader.cc View 3 chunks +11 lines, -15 lines 0 comments Download
M storage/browser/blob/blob_storage_context.cc View 8 chunks +13 lines, -13 lines 0 comments Download
M storage/browser/blob/blob_url_request_job_factory.cc View 3 chunks +5 lines, -3 lines 0 comments Download
M storage/browser/blob/internal_blob_data.cc View 2 chunks +2 lines, -1 line 0 comments Download
M storage/browser/blob/shareable_file_reference.cc View 3 chunks +3 lines, -2 lines 0 comments Download
M storage/browser/blob/upload_blob_element_reader.cc View 2 chunks +2 lines, -1 line 0 comments Download
M storage/browser/database/database_tracker.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M storage/browser/fileapi/async_file_util_adapter.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M storage/browser/fileapi/copy_or_move_operation_delegate.cc View 6 chunks +12 lines, -18 lines 0 comments Download
M storage/browser/fileapi/file_system_context.cc View 2 chunks +2 lines, -1 line 0 comments Download
M storage/browser/fileapi/file_system_operation_impl.cc View 20 chunks +30 lines, -34 lines 0 comments Download
M storage/browser/fileapi/file_system_operation_runner.cc View 3 chunks +8 lines, -8 lines 0 comments Download
M storage/browser/fileapi/file_writer_delegate.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M storage/browser/fileapi/obfuscated_file_util.cc View 6 chunks +6 lines, -6 lines 0 comments Download
M storage/browser/fileapi/plugin_private_file_system_backend.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M storage/browser/fileapi/quota/quota_reservation_manager.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M storage/browser/fileapi/sandbox_file_system_backend.cc View 2 chunks +3 lines, -1 line 0 comments Download
M storage/browser/fileapi/sandbox_file_system_backend_delegate.cc View 1 chunk +1 line, -1 line 0 comments Download
M storage/browser/fileapi/timed_task_helper.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M storage/browser/fileapi/transient_file_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M storage/browser/quota/quota_manager.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
dcheng
4 years, 12 months ago (2015-12-27 21:09:33 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1546243002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1546243002/1
4 years, 12 months ago (2015-12-27 21:10:00 UTC) #3
Avi (use Gerrit)
lgtm stampity stamp
4 years, 12 months ago (2015-12-27 21:22:39 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 12 months ago (2015-12-27 23:17:00 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1546243002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1546243002/1
4 years, 12 months ago (2015-12-27 23:18:49 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 12 months ago (2015-12-27 23:23:23 UTC) #9
commit-bot: I haz the power
4 years, 12 months ago (2015-12-27 23:24:20 UTC) #11
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/dae49253c1c80ffbdab640902fc1a5142d611c1a
Cr-Commit-Position: refs/heads/master@{#366944}

Powered by Google App Engine
This is Rietveld 408576698