Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(111)

Issue 1546223003: Issue 25314. Fix for incremental resolution of a function expression body in class declaration. (Closed)

Created:
4 years, 11 months ago by scheglov
Modified:
4 years, 11 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Issue 25314. Fix for incremental resolution of a function expression body in class declaration. R=brianwilkerson@google.com BUG= https://github.com/dart-lang/sdk/issues/25314 Committed: https://github.com/dart-lang/sdk/commit/8302308b715234d8d01520a5917c0fc839a47de9

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -1 line) Patch
M pkg/analyzer/lib/src/generated/incremental_resolver.dart View 2 chunks +3 lines, -1 line 0 comments Download
M pkg/analyzer/test/generated/incremental_resolver_test.dart View 1 chunk +21 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
scheglov
4 years, 11 months ago (2015-12-27 19:59:45 UTC) #1
Brian Wilkerson
LGTM
4 years, 11 months ago (2015-12-27 21:11:31 UTC) #2
scheglov
4 years, 11 months ago (2015-12-27 21:16:25 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
8302308b715234d8d01520a5917c0fc839a47de9 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698