Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(411)

Unified Diff: components/cronet/histogram_manager_unittest.cc

Issue 1546143002: Switch to standard integer types in components/, part 1 of 4. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/cronet/histogram_manager.cc ('k') | components/crx_file/constants.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/cronet/histogram_manager_unittest.cc
diff --git a/components/cronet/histogram_manager_unittest.cc b/components/cronet/histogram_manager_unittest.cc
index 62f7b918a77c275cf659f4fff6ab820f5d0d8b6a..8d4391ccaae41747682d7ac31072741c735a13ed 100644
--- a/components/cronet/histogram_manager_unittest.cc
+++ b/components/cronet/histogram_manager_unittest.cc
@@ -4,9 +4,10 @@
#include "components/cronet/histogram_manager.h"
+#include <stdint.h>
+
#include <string>
-#include "base/basictypes.h"
#include "base/metrics/statistics_recorder.h"
#include "testing/gtest/include/gtest/gtest.h"
@@ -19,13 +20,13 @@ TEST(HistogramManager, HistogramBucketFields) {
base::StatisticsRecorder::Initialize();
// Capture histograms at the start of the test to avoid later GetDeltas()
// calls picking them up.
- std::vector<uint8> data_init;
+ std::vector<uint8_t> data_init;
HistogramManager::GetInstance()->GetDeltas(&data_init);
// kNoFlags filter should record all histograms.
UMA_HISTOGRAM_ENUMERATION("UmaHistogramManager", 1, 2);
- std::vector<uint8> data;
+ std::vector<uint8_t> data;
EXPECT_TRUE(HistogramManager::GetInstance()->GetDeltas(&data));
EXPECT_FALSE(data.empty());
ChromeUserMetricsExtension uma_proto;
@@ -41,7 +42,7 @@ TEST(HistogramManager, HistogramBucketFields) {
EXPECT_EQ(1, histogram_proto.bucket(0).count());
UMA_HISTOGRAM_ENUMERATION("UmaHistogramManager2", 2, 3);
- std::vector<uint8> data2;
+ std::vector<uint8_t> data2;
EXPECT_TRUE(HistogramManager::GetInstance()->GetDeltas(&data2));
EXPECT_FALSE(data2.empty());
ChromeUserMetricsExtension uma_proto2;
« no previous file with comments | « components/cronet/histogram_manager.cc ('k') | components/crx_file/constants.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698