Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(347)

Issue 1546103002: Stop disabling compiler warning 4481, PDFium edition. (Closed)

Created:
4 years, 12 months ago by Lei Zhang
Modified:
4 years, 12 months ago
Reviewers:
Nico
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M build/standalone.gypi View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 5 (2 generated)
Lei Zhang
Don't forget V8.
4 years, 12 months ago (2015-12-24 18:57:34 UTC) #2
Nico
lgtm
4 years, 12 months ago (2015-12-25 04:56:52 UTC) #3
Lei Zhang
4 years, 12 months ago (2015-12-25 05:55:22 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
1ff4a733f3a50c121bebcff417743b7d84453cc5 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698