src/mips/builtins-mips.cc - Issue 1545983002: MIPS[64]: Fix test262/built-ins/Proxy/create-target-is-not-constructor.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/mips/builtins-mips.cc

Issue 1545983002: MIPS[64]: Fix test262/built-ins/Proxy/create-target-is-not-constructor. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/mips/builtins-mips.cc

diff --git a/src/mips/builtins-mips.cc b/src/mips/builtins-mips.cc

index 36c1b63c4f1784c826dafc81bfe1f7ae9194de5d..753cf75848d0c99e7d46e92a36eb7b3f90dd0c48 100644

--- a/src/mips/builtins-mips.cc

+++ b/src/mips/builtins-mips.cc

@@ -2038,7 +2038,7 @@ void Builtins::Generate_Construct(MacroAssembler* masm) {

// Check if target has a [[Construct]] internal method.

__ lbu(t3, FieldMemOperand(t1, Map::kBitFieldOffset));

- __ And(t3, t3, Operand(1 << Map::kIsCallable));

+ __ And(t3, t3, Operand(1 << Map::kIsConstructor));

__ Branch(&non_constructor, eq, t3, Operand(zero_reg));

// Only dispatch to proxies after checking whether they are constructors.

« no previous file with comments | « no previous file | src/mips64/builtins-mips64.cc » ('j') | no next file with comments »