MIPS[64]: Fix test262/built-ins/Proxy/create-target-is-not-constructor.

MIPS: Fix [es6] Introduce spec compliant IsConstructor.

In Builtins::Generate_Construct, the system was trying to
call ConstructProxy on a Proxy object without a constructor
because it was checking the wrong bit in the Proxy object's
supported operation mask.

TEST=test262/built-ins/Proxy/create-target-is-not-constructor
BUG=

Committed: https://crrev.com/78d8ce1bb1f040fc29d8c63ca0a38dfb610631a0
Cr-Commit-Position: refs/heads/master@{#33036}

[ivica.bogosavljevic, 2015-12-23 16:43:47]

Description was changed from

==========
MIPS[64]: Fix test262/built-ins/Proxy/create-target-is-not-constructor

Fix test262/built-ins/Proxy/create-target-is-not-constructor

TEST=test262/built-ins/Proxy/create-target-is-not-constructor
BUG=
==========

to

==========
MIPS[64]: Fix test262/built-ins/Proxy/create-target-is-not-constructor.

Fix test262/built-ins/Proxy/create-target-is-not-constructor.

TEST=test262/built-ins/Proxy/create-target-is-not-constructor
BUG=
==========

[ivica.bogosavljevic, 2015-12-23 16:45:51]

ivica.bogosavljevic@imgtec.com changed reviewers:
+ akos.palfi@mattakis.com, balazs.kilvady@imgtec.com, djordje.pesic@imgtec.com,
ilija.pavlovic@imgtec.com, miran.karic@imgtec.com, paul.lind@imgtec.com

[akos.palfi.imgtec, 2015-12-24 00:33:25]

akos.palfi@imgtec.com changed reviewers:
+ akos.palfi@imgtec.com, bmeurer@chromium.org

[akos.palfi.imgtec, 2015-12-24 00:33:25]

Nice catch! LGTM with nits:

The title should be: 'MIPS: Fix [es6] Introduce spec compliant IsConstructor.'

Please remove the redundant line: 'Fix
test262/built-ins/Proxy/create-target-is-not-constructor.', instead you should
briefly mention that the bit field checking is buggy here and you fix that by
checking the correct bit position.

[ivica.bogosavljevic, 2015-12-24 08:13:48]

The CQ bit was checked by ivica.bogosavljevic@imgtec.com to run a CQ dry run

[commit-bot: I haz the power, 2015-12-24 08:13:59]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1545983002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1545983002/1

[ivica.bogosavljevic, 2015-12-24 08:30:33]

Description was changed from

==========
MIPS[64]: Fix test262/built-ins/Proxy/create-target-is-not-constructor.

Fix test262/built-ins/Proxy/create-target-is-not-constructor.

TEST=test262/built-ins/Proxy/create-target-is-not-constructor
BUG=
==========

to

==========
MIPS: Fix [es6] Introduce spec compliant IsConstructor.

In Builtins::Generate_Construct, the system was trying to call ConstructProxy on
a Proxy object without a constructor because it was checking the wrong bit in
the Proxy object's supported operation mask.

TEST=test262/built-ins/Proxy/create-target-is-not-constructor
BUG=
==========

[ivica.bogosavljevic, 2015-12-24 08:30:55]

Description was changed from

==========
MIPS: Fix [es6] Introduce spec compliant IsConstructor.

In Builtins::Generate_Construct, the system was trying to call ConstructProxy on
a Proxy object without a constructor because it was checking the wrong bit in
the Proxy object's supported operation mask.

TEST=test262/built-ins/Proxy/create-target-is-not-constructor
BUG=
==========

to

==========
MIPS: Fix [es6] Introduce spec compliant IsConstructor.

In Builtins::Generate_Construct, the system was trying to
call ConstructProxy on a Proxy object without a constructor
because it was checking the wrong bit in the Proxy object's
supported operation mask.

TEST=test262/built-ins/Proxy/create-target-is-not-constructor
BUG=
==========

[commit-bot: I haz the power, 2015-12-24 08:33:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-12-24 08:33:25]

Dry run: This issue passed the CQ dry run.

[ivica.bogosavljevic, 2015-12-24 08:38:17]

The CQ bit was checked by ivica.bogosavljevic@imgtec.com

[commit-bot: I haz the power, 2015-12-24 08:38:20]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1545983002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1545983002/1

[commit-bot: I haz the power, 2015-12-24 08:40:14]

Description was changed from

==========
MIPS: Fix [es6] Introduce spec compliant IsConstructor.

In Builtins::Generate_Construct, the system was trying to
call ConstructProxy on a Proxy object without a constructor
because it was checking the wrong bit in the Proxy object's
supported operation mask.

TEST=test262/built-ins/Proxy/create-target-is-not-constructor
BUG=
==========

to

==========
MIPS: Fix [es6] Introduce spec compliant IsConstructor.

In Builtins::Generate_Construct, the system was trying to
call ConstructProxy on a Proxy object without a constructor
because it was checking the wrong bit in the Proxy object's
supported operation mask.

TEST=test262/built-ins/Proxy/create-target-is-not-constructor
BUG=
==========

[commit-bot: I haz the power, 2015-12-24 08:40:14]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2015-12-24 08:41:06]

Description was changed from

==========
MIPS: Fix [es6] Introduce spec compliant IsConstructor.

In Builtins::Generate_Construct, the system was trying to
call ConstructProxy on a Proxy object without a constructor
because it was checking the wrong bit in the Proxy object's
supported operation mask.

TEST=test262/built-ins/Proxy/create-target-is-not-constructor
BUG=
==========

to

==========
MIPS: Fix [es6] Introduce spec compliant IsConstructor.

In Builtins::Generate_Construct, the system was trying to
call ConstructProxy on a Proxy object without a constructor
because it was checking the wrong bit in the Proxy object's
supported operation mask.

TEST=test262/built-ins/Proxy/create-target-is-not-constructor
BUG=

Committed: https://crrev.com/78d8ce1bb1f040fc29d8c63ca0a38dfb610631a0
Cr-Commit-Position: refs/heads/master@{#33036}
==========

[commit-bot: I haz the power, 2015-12-24 08:41:07]

Patchset 1 (id:??) landed as
https://crrev.com/78d8ce1bb1f040fc29d8c63ca0a38dfb610631a0
Cr-Commit-Position: refs/heads/master@{#33036}

[Benedikt Meurer, 2015-12-24 19:14:32]

Thanks for fixing this, and merry christmas :-)