content/browser/web_contents/aura/overscroll_navigation_overlay_unittest.cc - Issue 1545973002: Remove the is_loading_ field from WebContentsImpl

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/web_contents/aura/overscroll_navigation_overlay_unittest.cc

Issue 1545973002: Remove the is_loading_ field from WebContentsImpl (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/frame_host/frame_tree_node.cc ('K') | « content/browser/frame_host/render_frame_host_manager.cc ('k') | content/browser/web_contents/web_contents_impl.h » ('j') | content/browser/web_contents/web_contents_impl.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/web_contents/aura/overscroll_navigation_overlay_unittest.cc

diff --git a/content/browser/web_contents/aura/overscroll_navigation_overlay_unittest.cc b/content/browser/web_contents/aura/overscroll_navigation_overlay_unittest.cc

index 97dd750160c48838de78b3654247530be7afe989..9d43e9296a76789082fb2be842005c6d56feb338 100644

--- a/content/browser/web_contents/aura/overscroll_navigation_overlay_unittest.cc

+++ b/content/browser/web_contents/aura/overscroll_navigation_overlay_unittest.cc

@@ -307,7 +307,6 @@ TEST_F(OverscrollNavigationOverlayTest, Navigation_LoadingUpdate) {

// this is a "safety net" in case we mis-identify the destination webpage

// (which can happen if a new navigation is performed while while a GestureNav

// navigation is in progress).

- contents()->TestSetIsLoading(true);

contents()->TestSetIsLoading(false);

EXPECT_FALSE(GetOverlay()->web_contents());

NavigationEntry* pending = contents()->GetController().GetPendingEntry();