Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5861)

Unified Diff: content/browser/frame_host/navigation_controller_delegate.h

Issue 1545973002: Remove the is_loading_ field from WebContentsImpl (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase + addressed Nasko's nits Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/frame_host/navigation_controller_delegate.h
diff --git a/content/browser/frame_host/navigation_controller_delegate.h b/content/browser/frame_host/navigation_controller_delegate.h
index 9922ac59817e12c4e0c88a882e1ab3a25c0bc1ba..8a20e2bcd0171c58b833bddbc3a2698fca45fae3 100644
--- a/content/browser/frame_host/navigation_controller_delegate.h
+++ b/content/browser/frame_host/navigation_controller_delegate.h
@@ -42,7 +42,6 @@ class NavigationControllerDelegate {
virtual void Stop() = 0;
virtual int32_t GetMaxPageID() = 0;
virtual int32_t GetMaxPageIDForSiteInstance(SiteInstance* site_instance) = 0;
- virtual bool IsLoading() const = 0;
virtual bool IsBeingDestroyed() const = 0;
virtual bool CanOverscrollContent() const = 0;
@@ -71,10 +70,8 @@ class NavigationControllerDelegate {
RenderFrameHost* render_frame_host) = 0;
virtual void AttachInterstitialPage(
InterstitialPageImpl* interstitial_page) = 0;
+ virtual void DidProceedOnInterstitial() = 0;
virtual void DetachInterstitialPage() = 0;
- virtual void SetIsLoading(bool is_loading,
- bool to_different_document,
- LoadNotificationDetails* details) = 0;
};
} // namespace content

Powered by Google App Engine
This is Rietveld 408576698