chrome/browser/extensions/extension_resource_request_policy_apitest.cc - Issue 1545973002: Remove the is_loading_ field from WebContentsImpl

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/extension_resource_request_policy_apitest.cc

Issue 1545973002: Remove the is_loading_ field from WebContentsImpl (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: No more changes to SubframeTaskBrowserTest since transfers work Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/extensions/extension_resource_request_policy_apitest.cc

diff --git a/chrome/browser/extensions/extension_resource_request_policy_apitest.cc b/chrome/browser/extensions/extension_resource_request_policy_apitest.cc

index 348f95839fb7eb3d7449073cb56ff3ab3955847d..bb5a30a0c2bb0d04e37cd990cbd7f1b56179abc2 100644

--- a/chrome/browser/extensions/extension_resource_request_policy_apitest.cc

+++ b/chrome/browser/extensions/extension_resource_request_policy_apitest.cc

@@ -227,7 +227,7 @@ IN_PROC_BROWSER_TEST_F(ExtensionResourceRequestPolicyTest,

"web_accessible/accessible_history_navigation.html"));

ui_test_utils::NavigateToURL(browser(), newtab_page);

ui_test_utils::NavigateToURLBlockUntilNavigationsComplete(

- browser(), accessible_newtab_override, 2);

+ browser(), accessible_newtab_override, 1);

ASSERT_TRUE(content::ExecuteScriptAndExtractString(

browser()->tab_strip_model()->GetActiveWebContents(),

"window.domAutomationController.send(document.title)",

@@ -246,8 +246,8 @@ IN_PROC_BROWSER_TEST_F(ExtensionResourceRequestPolicyTest,

GURL accessible_linked_resource(embedded_test_server()->GetURL(

"/extensions/api_test/extension_resource_request_policy/"

"web_accessible/accessible_link_resource.html"));

- ui_test_utils::NavigateToURLBlockUntilNavigationsComplete(browser(),

- accessible_linked_resource, 2);

+ ui_test_utils::NavigateToURLBlockUntilNavigationsComplete(

+ browser(), accessible_linked_resource, 1);

ASSERT_TRUE(content::ExecuteScriptAndExtractString(

browser()->tab_strip_model()->GetActiveWebContents(),

"window.domAutomationController.send(document.URL)",

« no previous file with comments | « no previous file | content/browser/frame_host/frame_tree.h » ('j') | content/browser/frame_host/navigator_impl.cc » ('J')