Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(490)

Unified Diff: content/browser/frame_host/render_frame_host_impl.h

Issue 1545973002: Remove the is_loading_ field from WebContentsImpl (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixed issue with tests Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/frame_host/render_frame_host_impl.h
diff --git a/content/browser/frame_host/render_frame_host_impl.h b/content/browser/frame_host/render_frame_host_impl.h
index 61c61a32b0a6a3e0b1853a8b27610bbaa3ace65e..26ee08e725c410b7171ab3d395d8062b6255d7d9 100644
--- a/content/browser/frame_host/render_frame_host_impl.h
+++ b/content/browser/frame_host/render_frame_host_impl.h
@@ -95,9 +95,9 @@ enum CreateRenderFrameFlags {
CREATE_RF_HIDDEN = 1 << 1,
};
-class CONTENT_EXPORT RenderFrameHostImpl
- : public RenderFrameHost,
- public BrowserAccessibilityDelegate {
+class CONTENT_EXPORT RenderFrameHostImpl : public RenderFrameHost,
+ public BrowserAccessibilityDelegate,
+ public SiteInstanceImpl::Observer {
public:
using AXTreeSnapshotCallback =
base::Callback<void(
@@ -206,6 +206,9 @@ class CONTENT_EXPORT RenderFrameHostImpl
gfx::AcceleratedWidget AccessibilityGetAcceleratedWidget() override;
gfx::NativeViewAccessible AccessibilityGetNativeViewAccessible() override;
+ // SiteInstanceImpl::Observer
+ void RenderProcessGone(SiteInstanceImpl* site_instance) override;
+
// Creates a RenderFrame in the renderer process.
bool CreateRenderFrame(int proxy_routing_id,
int opener_routing_id,
@@ -525,6 +528,10 @@ class CONTENT_EXPORT RenderFrameHostImpl
// Returns the Mojo ImageDownloader service.
const image_downloader::ImageDownloaderPtr& GetMojoImageDownloader();
+ // Resets the loading state. Following this call, the RenderFrameHost will be
+ // in a non-loading state.
+ void ResetLoadingState();
+
protected:
friend class RenderFrameHostFactory;
@@ -570,7 +577,6 @@ class CONTENT_EXPORT RenderFrameHostImpl
const base::string16& error_description,
bool was_ignored_by_handler);
void OnDidCommitProvisionalLoad(const IPC::Message& msg);
- void OnDidDropNavigation();
void OnUpdateState(const PageState& state);
void OnBeforeUnloadACK(
bool proceed,

Powered by Google App Engine
This is Rietveld 408576698