content/browser/frame_host/navigation_controller_impl_unittest.cc - Issue 1545973002: Remove the is_loading_ field from WebContentsImpl

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/frame_host/navigation_controller_impl_unittest.cc

Issue 1545973002: Remove the is_loading_ field from WebContentsImpl (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix compilation error on windows Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/frame_host/navigation_controller_impl_unittest.cc

diff --git a/content/browser/frame_host/navigation_controller_impl_unittest.cc b/content/browser/frame_host/navigation_controller_impl_unittest.cc

index 775feb3debf69d04b8a1b09e76f1337665ef18f5..b4b60c463557dc6b62ddbb399fc131cf8d290979 100644

--- a/content/browser/frame_host/navigation_controller_impl_unittest.cc

+++ b/content/browser/frame_host/navigation_controller_impl_unittest.cc

@@ -3477,7 +3477,7 @@ TEST_F(NavigationControllerTest, ShowBrowserURLAfterFailUntilModified) {

params.showing_repost_interstitial = false;

main_test_rfh()->OnMessageReceived(

FrameHostMsg_DidFailProvisionalLoadWithError(0, params));

- contents()->SetIsLoading(false, true, NULL);

+ main_test_rfh()->OnMessageReceived(FrameHostMsg_DidStopLoading(0));

EXPECT_EQ(url, controller.GetVisibleEntry()->GetURL());

// If something else later modifies the contents of the about:blank page, then