content/browser/site_instance_impl.h - Issue 1545973002: Remove the is_loading_ field from WebContentsImpl

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/site_instance_impl.h

Issue 1545973002: Remove the is_loading_ field from WebContentsImpl (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Reenabled 2 tests Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/site_instance_impl.h

diff --git a/content/browser/site_instance_impl.h b/content/browser/site_instance_impl.h

index b54de7f5886673ad1cf39193233641b751121df4..d7bdf056ea7d1990b367f3ce12958cbb78ed89a3 100644

--- a/content/browser/site_instance_impl.h

+++ b/content/browser/site_instance_impl.h

@@ -27,7 +27,7 @@ class CONTENT_EXPORT SiteInstanceImpl : public SiteInstance,

public:

// Called when this SiteInstance transitions to having no active frames,

// as measured by active_frame_count().

- virtual void ActiveFrameCountIsZero(SiteInstanceImpl* site_instance) = 0;

+ virtual void ActiveFrameCountIsZero(SiteInstanceImpl* site_instance) {}

// Called when the renderer process of this SiteInstance has exited.

virtual void RenderProcessGone(SiteInstanceImpl* site_instance) = 0;