Remove the is_loading_ field from WebContentsImpl

content/test/web_contents_observer_sanity_checker.cc

Index: content/test/web_contents_observer_sanity_checker.cc
diff --git a/content/test/web_contents_observer_sanity_checker.cc b/content/test/web_contents_observer_sanity_checker.cc
index 8ac2dd0f199b84158997e211d665083696d95ce3..170e5888daecc9b207c3518881b8e5f63b761fe1 100644
--- a/content/test/web_contents_observer_sanity_checker.cc
+++ b/content/test/web_contents_observer_sanity_checker.cc
@@ -332,10 +332,21 @@ void WebContentsObserverSanityChecker::WebContentsDestroyed() {
   CHECK(active_media_players_.empty());
 }
 
+void WebContentsObserverSanityChecker::DidStartLoading() {
+  CHECK(!is_loading_);
+  is_loading_ = true;

[nasko, 2016/01/20 20:58:34]

Now that we have the loading state, we should assert its value in all of the
navigation observer APIs. Feel free to do this in a separate CL if you wish.

[clamy, 2016/01/22 13:08:15]

Will do that in a separate CL. Added a TODO for it.

+}
+
+void WebContentsObserverSanityChecker::DidStopLoading() {
+  CHECK(is_loading_);
+  is_loading_ = false;
+}
+
 WebContentsObserverSanityChecker::WebContentsObserverSanityChecker(
     WebContents* web_contents)
-    : WebContentsObserver(web_contents), web_contents_destroyed_(false) {
-}
+    : WebContentsObserver(web_contents),
+      is_loading_(false),
+      web_contents_destroyed_(false) {}
 
 WebContentsObserverSanityChecker::~WebContentsObserverSanityChecker() {
   CHECK(web_contents_destroyed_);