chrome/browser/task_management/providers/web_contents/subframe_task_browsertest.cc - Issue 1545973002: Remove the is_loading_ field from WebContentsImpl

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/task_management/providers/web_contents/subframe_task_browsertest.cc

Issue 1545973002: Remove the is_loading_ field from WebContentsImpl (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixed issue with swapped-out RFHs Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/extension_resource_request_policy_apitest.cc ('k') | content/browser/frame_host/frame_tree.h » ('j') | content/browser/frame_host/render_frame_host_impl.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/task_management/providers/web_contents/subframe_task_browsertest.cc

diff --git a/chrome/browser/task_management/providers/web_contents/subframe_task_browsertest.cc b/chrome/browser/task_management/providers/web_contents/subframe_task_browsertest.cc

index 616388390559e5c7f58d2cc310d8cdc69a66e303..b6b972c350ac760e7e05ff592c3fa4423a2eab05 100644

--- a/chrome/browser/task_management/providers/web_contents/subframe_task_browsertest.cc

+++ b/chrome/browser/task_management/providers/web_contents/subframe_task_browsertest.cc

@@ -117,7 +117,8 @@ IN_PROC_BROWSER_TEST_F(SubframeTaskBrowserTest, TaskManagerShowsSubframeTasks) {

// If we navigate to the simple page on a.com which doesn't have cross-site

// iframes, we expect not to have any SubframeTasks.

- NavigateTo(kSimplePageUrl);

+ ui_test_utils::NavigateToURLBlockUntilNavigationsComplete(

+ browser(), embedded_test_server()->GetURL(kSimplePageUrl), 2);

ASSERT_EQ(1U, task_manager.tasks().size());

const Task* simple_page_task = task_manager.tasks().front();