Remove the is_loading_ field from WebContentsImpl

content/renderer/render_frame_impl.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/renderer/render_frame_impl.h"
 
 #include <map>
 #include <string>
 #include <utility>
 #include <vector>
@@ skipping 4558 matching lines @@
       routing_id_, common_params.url, common_params.navigation_start));
 
   // Send the provisional load failure.
   blink::WebURLError error =
       CreateWebURLError(common_params.url, has_stale_copy_in_cache, error_code);
   WebURLRequest failed_request = CreateURLRequestForNavigation(
       common_params, scoped_ptr<StreamOverrideParameters>(),
       frame_->isViewSourceModeEnabled());
   SendFailedProvisionalLoad(failed_request, error, frame_);
 
+  // This check should have been done on the browser side already.
   if (!ShouldDisplayErrorPageForFailedLoad(error_code, common_params.url)) {
-    // TODO(avi): Remove this; we shouldn't ever be dropping navigations.
-    // http://crbug.com/501960
-    Send(new FrameHostMsg_DidDropNavigation(routing_id_));
+    NOTREACHED();

[nasko, 2016/01/15 01:19:16]

Shouldn't this be CHECK for a short period of time to ensure we don't hit this
in the wild? I think avi@ needs to weigh in on this one.

[Avi (use Gerrit), 2016/01/15 04:48:00]

In the comment when I said that we "shouldn't ever be dropping navigations", I
meant that in a philosophical sense of "it's bad design to drop navigations,
since we only cause weird corner cases, so we should re-design and re-work
Chrome to not do that." Perhaps my comment wasn't as clear as it could be.

In any case, I did not mean NOTREACHED. ShouldDisplayErrorPageForFailedLoad is
going to return |false| (in fact, the whole point of that function is to
sometimes return true and sometimes false) so to explode it in that case is bad
form.

[clamy, 2016/01/15 16:47:44]

This is is a PlzNavigate only method, and I realize now that it is not properly
indicated. In that case the filtering should be done on the browser side so it
really should be NOTREACHED. I added the proper markings of a PlzNavigate method
to make it clearer.

     return;
   }
 
   // Make sure errors are not shown in view source mode.
   frame_->enableViewSourceMode(false);
 
   // Replace the current history entry in reloads, history navigations and loads
   // of the same url. This corresponds to Blink's notion of a standard
   // commit.
   // TODO(clamy): see if initial commits in subframes should be handled
@@ skipping 527 matching lines @@
     // Perform a navigation to a data url if needed.
     if (!common_params.base_url_for_data_url.is_empty() ||
         (browser_side_navigation &&
          common_params.url.SchemeIs(url::kDataScheme))) {
       LoadDataURL(common_params, request_params, frame_, load_type);
     } else {
       // Load the request.
       frame_->toWebLocalFrame()->load(request, load_type,
                                       item_for_history_navigation);
     }
+  } else {
+    // The browser expects the frame to be loading this navigation. Informs it

[nasko, 2016/01/15 01:19:16]

Inform

[clamy, 2016/01/15 16:47:44]

Done.

+    // that the load stopped if needed.
+    if (!frame_->isLoading())
+      Send(new FrameHostMsg_DidStopLoading(routing_id_));
   }
 
   // In case LoadRequest failed before didCreateDataSource was called.
   pending_navigation_params_.reset();
 }
 
 void RenderFrameImpl::UpdateEncoding(WebFrame* frame,
                                      const std::string& encoding_name) {
   // Only update main frame's encoding_name.
   if (!frame->parent())
@@ skipping 561 matching lines @@
       media::ConvertToSwitchOutputDeviceCB(web_callbacks);
   scoped_refptr<media::AudioOutputDevice> device =
       AudioDeviceFactory::NewOutputDevice(routing_id_, 0, sink_id.utf8(),
                                           security_origin);
   media::OutputDeviceStatus status = device->GetDeviceStatus();
   device->Stop();
   callback.Run(status);
 }
 
 }  // namespace content