Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(108)

Side by Side Diff: content/browser/frame_host/frame_tree_node.h

Issue 1545973002: Remove the is_loading_ field from WebContentsImpl (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CONTENT_BROWSER_FRAME_HOST_FRAME_TREE_NODE_H_ 5 #ifndef CONTENT_BROWSER_FRAME_HOST_FRAME_TREE_NODE_H_
6 #define CONTENT_BROWSER_FRAME_HOST_FRAME_TREE_NODE_H_ 6 #define CONTENT_BROWSER_FRAME_HOST_FRAME_TREE_NODE_H_
7 7
8 #include <stddef.h> 8 #include <stddef.h>
9 9
10 #include <string> 10 #include <string>
(...skipping 218 matching lines...) Expand 10 before | Expand all | Expand 10 after
229 // FrameTree::ForEach to stop all loads in the entire FrameTree. 229 // FrameTree::ForEach to stop all loads in the entire FrameTree.
230 bool StopLoading(); 230 bool StopLoading();
231 231
232 // Returns the time this frame was last focused. 232 // Returns the time this frame was last focused.
233 base::TimeTicks last_focus_time() const { return last_focus_time_; } 233 base::TimeTicks last_focus_time() const { return last_focus_time_; }
234 234
235 // Called when this node becomes focused. Updates the node's last focused 235 // Called when this node becomes focused. Updates the node's last focused
236 // time and notifies observers. 236 // time and notifies observers.
237 void DidFocus(); 237 void DidFocus();
238 238
239 // Called when a RenderViewHost was terminated. This will inform the current
240 // or the pending RenderFrameHost of the RenderViewHost termination should
241 // they be associated with |render_view_host|.
242 void RenderViewTerminated(RenderViewHostImpl* render_view_host);
nasko 2016/01/15 01:19:16 Why do we need this method?
clamy 2016/01/15 16:47:44 Method removed. The loading state is now reset in
243
244 // Called when the user closed the modal dialogue for BeforeUnload. This
nasko 2016/01/15 01:19:16 Let's add to the comment that it is called only wh
clamy 2016/01/15 16:47:44 Done.
245 // should stop the loads.
246 void BeforeUnloadCanceled();
247
239 private: 248 private:
240 class OpenerDestroyedObserver; 249 class OpenerDestroyedObserver;
241 250
242 void set_parent(FrameTreeNode* parent) { parent_ = parent; } 251 void set_parent(FrameTreeNode* parent) { parent_ = parent; }
243 252
244 // The next available browser-global FrameTreeNode ID. 253 // The next available browser-global FrameTreeNode ID.
245 static int next_frame_tree_node_id_; 254 static int next_frame_tree_node_id_;
246 255
247 // The FrameTree that owns us. 256 // The FrameTree that owns us.
248 FrameTree* frame_tree_; // not owned. 257 FrameTree* frame_tree_; // not owned.
(...skipping 74 matching lines...) Expand 10 before | Expand all | Expand 10 after
323 base::ObserverList<Observer> observers_; 332 base::ObserverList<Observer> observers_;
324 333
325 base::TimeTicks last_focus_time_; 334 base::TimeTicks last_focus_time_;
326 335
327 DISALLOW_COPY_AND_ASSIGN(FrameTreeNode); 336 DISALLOW_COPY_AND_ASSIGN(FrameTreeNode);
328 }; 337 };
329 338
330 } // namespace content 339 } // namespace content
331 340
332 #endif // CONTENT_BROWSER_FRAME_HOST_FRAME_TREE_NODE_H_ 341 #endif // CONTENT_BROWSER_FRAME_HOST_FRAME_TREE_NODE_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698