content/browser/frame_host/navigation_controller_delegate.h - Issue 1545973002: Remove the is_loading_ field from WebContentsImpl

Side by Side Diff: content/browser/frame_host/navigation_controller_delegate.h

Issue 1545973002: Remove the is_loading_ field from WebContentsImpl (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixed issue with tests Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « content/browser/frame_host/interstitial_page_impl.cc ('k') | content/browser/frame_host/navigation_controller_impl_unittest.cc » ('j') | content/browser/web_contents/web_contents_impl.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright 2013 The Chromium Authors. All rights reserved.	1 // Copyright 2013 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #ifndef CONTENT_BROWSER_FRAME_HOST_NAVIGATION_CONTROLLER_DELEGATE_H_	5 #ifndef CONTENT_BROWSER_FRAME_HOST_NAVIGATION_CONTROLLER_DELEGATE_H_

6 #define CONTENT_BROWSER_FRAME_HOST_NAVIGATION_CONTROLLER_DELEGATE_H_	6 #define CONTENT_BROWSER_FRAME_HOST_NAVIGATION_CONTROLLER_DELEGATE_H_

7	7

8 #include <stdint.h>	8 #include <stdint.h>

9	9

10 #include <string>	10 #include <string>

(...skipping 24 matching lines...) Expand all Loading...
35 virtual ~NavigationControllerDelegate() {}	35 virtual ~NavigationControllerDelegate() {}

36	36

37 // Duplicates of WebContents methods.	37 // Duplicates of WebContents methods.

38 virtual RenderViewHost* GetRenderViewHost() const = 0;	38 virtual RenderViewHost* GetRenderViewHost() const = 0;

39 virtual InterstitialPage* GetInterstitialPage() const = 0;	39 virtual InterstitialPage* GetInterstitialPage() const = 0;

40 virtual const std::string& GetContentsMimeType() const = 0;	40 virtual const std::string& GetContentsMimeType() const = 0;

41 virtual void NotifyNavigationStateChanged(InvalidateTypes changed_flags) = 0;	41 virtual void NotifyNavigationStateChanged(InvalidateTypes changed_flags) = 0;

42 virtual void Stop() = 0;	42 virtual void Stop() = 0;

43 virtual int32_t GetMaxPageID() = 0;	43 virtual int32_t GetMaxPageID() = 0;

44 virtual int32_t GetMaxPageIDForSiteInstance(SiteInstance* site_instance) = 0;	44 virtual int32_t GetMaxPageIDForSiteInstance(SiteInstance* site_instance) = 0;

45 virtual bool IsLoading() const = 0;

46 virtual bool IsBeingDestroyed() const = 0;	45 virtual bool IsBeingDestroyed() const = 0;

47 virtual bool CanOverscrollContent() const = 0;	46 virtual bool CanOverscrollContent() const = 0;

48	47

49 // Methods from WebContentsImpl that NavigationControllerImpl needs to	48 // Methods from WebContentsImpl that NavigationControllerImpl needs to

50 // call.	49 // call.

51 virtual FrameTree* GetFrameTree() = 0;	50 virtual FrameTree* GetFrameTree() = 0;

52 virtual void NotifyBeforeFormRepostWarningShow() = 0;	51 virtual void NotifyBeforeFormRepostWarningShow() = 0;

53 virtual void NotifyNavigationEntryCommitted(	52 virtual void NotifyNavigationEntryCommitted(

54 const LoadCommittedDetails& load_details) = 0;	53 const LoadCommittedDetails& load_details) = 0;

55 virtual void SetHistoryOffsetAndLength(int history_offset,	54 virtual void SetHistoryOffsetAndLength(int history_offset,

56 int history_length) = 0;	55 int history_length) = 0;

57 virtual void CopyMaxPageIDsFrom(WebContents* web_contents) = 0;	56 virtual void CopyMaxPageIDsFrom(WebContents* web_contents) = 0;

58 virtual void UpdateMaxPageID(int32_t page_id) = 0;	57 virtual void UpdateMaxPageID(int32_t page_id) = 0;

59 virtual void UpdateMaxPageIDForSiteInstance(SiteInstance* site_instance,	58 virtual void UpdateMaxPageIDForSiteInstance(SiteInstance* site_instance,

60 int32_t page_id) = 0;	59 int32_t page_id) = 0;

61 virtual void ActivateAndShowRepostFormWarningDialog() = 0;	60 virtual void ActivateAndShowRepostFormWarningDialog() = 0;

62 virtual bool HasAccessedInitialDocument() = 0;	61 virtual bool HasAccessedInitialDocument() = 0;

63	62

64 // This method is needed, since we are no longer guaranteed that the	63 // This method is needed, since we are no longer guaranteed that the

65 // embedder for NavigationController will be a WebContents object.	64 // embedder for NavigationController will be a WebContents object.

66 virtual WebContents* GetWebContents() = 0;	65 virtual WebContents* GetWebContents() = 0;

67	66

68 // Methods needed by InterstitialPageImpl.	67 // Methods needed by InterstitialPageImpl.

69 virtual bool IsHidden() = 0;	68 virtual bool IsHidden() = 0;

70 virtual void RenderFrameForInterstitialPageCreated(	69 virtual void RenderFrameForInterstitialPageCreated(

71 RenderFrameHost* render_frame_host) = 0;	70 RenderFrameHost* render_frame_host) = 0;

72 virtual void AttachInterstitialPage(	71 virtual void AttachInterstitialPage(

73 InterstitialPageImpl* interstitial_page) = 0;	72 InterstitialPageImpl* interstitial_page) = 0;

	73 virtual void DidProceedOnInterstitial() = 0;

74 virtual void DetachInterstitialPage() = 0;	74 virtual void DetachInterstitialPage() = 0;

75 virtual void SetIsLoading(bool is_loading,

76 bool to_different_document,

77 LoadNotificationDetails* details) = 0;

78 };	75 };

79	76

80 } // namespace content	77 } // namespace content

81	78

82 #endif // CONTENT_BROWSER_FRAME_HOST_NAVIGATION_CONTROLLER_DELEGATE_H_	79 #endif // CONTENT_BROWSER_FRAME_HOST_NAVIGATION_CONTROLLER_DELEGATE_H_

OLD	NEW