Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(148)

Side by Side Diff: content/browser/frame_host/render_frame_host_impl.h

Issue 1545973002: Remove the is_loading_ field from WebContentsImpl (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressed Nasko's comments Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CONTENT_BROWSER_FRAME_HOST_RENDER_FRAME_HOST_IMPL_H_ 5 #ifndef CONTENT_BROWSER_FRAME_HOST_RENDER_FRAME_HOST_IMPL_H_
6 #define CONTENT_BROWSER_FRAME_HOST_RENDER_FRAME_HOST_IMPL_H_ 6 #define CONTENT_BROWSER_FRAME_HOST_RENDER_FRAME_HOST_IMPL_H_
7 7
8 #include <stddef.h> 8 #include <stddef.h>
9 #include <stdint.h> 9 #include <stdint.h>
10 10
(...skipping 505 matching lines...) Expand 10 before | Expand all | Expand 10 after
516 516
517 // Destroys the pending WebUI and resets related data. 517 // Destroys the pending WebUI and resets related data.
518 void ClearPendingWebUI(); 518 void ClearPendingWebUI();
519 519
520 // Destroys all WebUI instances and resets related data. 520 // Destroys all WebUI instances and resets related data.
521 void ClearAllWebUI(); 521 void ClearAllWebUI();
522 522
523 // Returns the Mojo ImageDownloader service. 523 // Returns the Mojo ImageDownloader service.
524 const image_downloader::ImageDownloaderPtr& GetMojoImageDownloader(); 524 const image_downloader::ImageDownloaderPtr& GetMojoImageDownloader();
525 525
526 // Resets the loading state. Following this call, the RenderFrameHost will be
527 // in a non-loading state.
528 void ResetLoadingState();
529
526 protected: 530 protected:
527 friend class RenderFrameHostFactory; 531 friend class RenderFrameHostFactory;
528 532
529 // |flags| is a combination of CreateRenderFrameFlags. 533 // |flags| is a combination of CreateRenderFrameFlags.
530 // TODO(nasko): Remove dependency on RenderViewHost here. RenderProcessHost 534 // TODO(nasko): Remove dependency on RenderViewHost here. RenderProcessHost
531 // should be the abstraction needed here, but we need RenderViewHost to pass 535 // should be the abstraction needed here, but we need RenderViewHost to pass
532 // into WebContentsObserver::FrameDetached for now. 536 // into WebContentsObserver::FrameDetached for now.
533 RenderFrameHostImpl(SiteInstance* site_instance, 537 RenderFrameHostImpl(SiteInstance* site_instance,
534 RenderViewHostImpl* render_view_host, 538 RenderViewHostImpl* render_view_host,
535 RenderFrameHostDelegate* delegate, 539 RenderFrameHostDelegate* delegate,
(...skipping 25 matching lines...) Expand all
561 const GURL& url, 565 const GURL& url,
562 const base::TimeTicks& navigation_start); 566 const base::TimeTicks& navigation_start);
563 void OnDidFailProvisionalLoadWithError( 567 void OnDidFailProvisionalLoadWithError(
564 const FrameHostMsg_DidFailProvisionalLoadWithError_Params& params); 568 const FrameHostMsg_DidFailProvisionalLoadWithError_Params& params);
565 void OnDidFailLoadWithError( 569 void OnDidFailLoadWithError(
566 const GURL& url, 570 const GURL& url,
567 int error_code, 571 int error_code,
568 const base::string16& error_description, 572 const base::string16& error_description,
569 bool was_ignored_by_handler); 573 bool was_ignored_by_handler);
570 void OnDidCommitProvisionalLoad(const IPC::Message& msg); 574 void OnDidCommitProvisionalLoad(const IPC::Message& msg);
571 void OnDidDropNavigation();
572 void OnUpdateState(const PageState& state); 575 void OnUpdateState(const PageState& state);
573 void OnBeforeUnloadACK( 576 void OnBeforeUnloadACK(
574 bool proceed, 577 bool proceed,
575 const base::TimeTicks& renderer_before_unload_start_time, 578 const base::TimeTicks& renderer_before_unload_start_time,
576 const base::TimeTicks& renderer_before_unload_end_time); 579 const base::TimeTicks& renderer_before_unload_end_time);
577 void OnSwapOutACK(); 580 void OnSwapOutACK();
578 void OnRenderProcessGone(int status, int error_code); 581 void OnRenderProcessGone(int status, int error_code);
579 void OnContextMenu(const ContextMenuParams& params); 582 void OnContextMenu(const ContextMenuParams& params);
580 void OnJavaScriptExecuteResponse(int id, const base::ListValue& result); 583 void OnJavaScriptExecuteResponse(int id, const base::ListValue& result);
581 void OnVisualStateResponse(uint64_t id); 584 void OnVisualStateResponse(uint64_t id);
(...skipping 308 matching lines...) Expand 10 before | Expand all | Expand 10 after
890 893
891 // NOTE: This must be the last member. 894 // NOTE: This must be the last member.
892 base::WeakPtrFactory<RenderFrameHostImpl> weak_ptr_factory_; 895 base::WeakPtrFactory<RenderFrameHostImpl> weak_ptr_factory_;
893 896
894 DISALLOW_COPY_AND_ASSIGN(RenderFrameHostImpl); 897 DISALLOW_COPY_AND_ASSIGN(RenderFrameHostImpl);
895 }; 898 };
896 899
897 } // namespace content 900 } // namespace content
898 901
899 #endif // CONTENT_BROWSER_FRAME_HOST_RENDER_FRAME_HOST_IMPL_H_ 902 #endif // CONTENT_BROWSER_FRAME_HOST_RENDER_FRAME_HOST_IMPL_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698