Refactor pref code out of ProfileImpl.

Refactor pref code out of ProfileImpl.

Moved into the chrome_pref_service_factory.cc

ProfileImpl no longer has any notion of the Preferences file. This knowledge lives strictly in chrome_pref_service_factory.cc which now implements everything that needs to know about that file's path.

As per noms@'s request on https://codereview.chromium.org/145053004/

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=249095
Reverted: https://src.chromium.org/viewvc/chrome?view=rev&revision=249100

R=bauerb@chromium.org, erikwright@chromium.org, jochen@chromium.org, noms@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=249123

[gab, 2014-02-04 22:10:06]

Erik/Noms/Bernhard; PTAL.

Thanks!
Gab

[noms (inactive), 2014-02-05 15:38:15]

profiles lgtm. Thanks Gab!

[Bernhard Bauer, 2014-02-05 15:50:30]

lgtm

[erikwright (departed), 2014-02-05 15:59:22]

LGTM. Once you move the master prefs stuff you should be able to get rid of
GetDefaultPrefFilePath (first_run.cc) and profiles::GetDefaultProfileDir
(profile_state.cc).

That will nearly eliminate all references to the profile path name outside of
chrome_pref_service_factory.

[gab, 2014-02-05 16:05:16]

The CQ bit was checked by gab@chromium.org

[commit-bot: I haz the power, 2014-02-05 16:10:07]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/gab@chromium.org/154593002/30002

[commit-bot: I haz the power, 2014-02-05 16:58:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-02-05 16:58:11]

Retried try job too often on chromium_presubmit for step(s) presubmit
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_p...

[gab, 2014-02-05 18:03:53]

TBR jochen for chrome/browser/chrome_browser_main.cc change resulting from API
change side-effects.

[gab, 2014-02-05 18:04:14]

The CQ bit was checked by gab@chromium.org

[commit-bot: I haz the power, 2014-02-05 18:09:55]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/gab@chromium.org/154593002/30002

[jochen (gone - plz use gerrit), 2014-02-05 19:52:28]

lgtm

[commit-bot: I haz the power, 2014-02-05 20:09:58]

Change committed as 249095

[gab, 2014-02-05 21:48:05]

Committed patchset #4 manually as r249123 (presubmit successful).

[gab, 2014-02-05 21:49:10]

On 2014/02/05 21:48:05, gab wrote:
> Committed patchset #4 manually as r249123 (presubmit successful).

Reverted in 249100 for a missing include; fixed and dcommitted back (previous
patch set had passed CQ).