Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(237)

Issue 1545913002: Remove unused print_output argument from upload.py (Closed)

Created:
5 years ago by Daniel Bratell
Modified:
5 years ago
CC:
chromium-reviews, dpranke+depot_tools_chromium.org, iannucci+depot_tools_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/depot_tools.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -31 lines) Patch
M third_party/upload.py View 3 chunks +8 lines, -31 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Daniel Bratell
Cleanup patch. Please take a look. I don't have any good way of testing it, ...
5 years ago (2015-12-23 07:46:38 UTC) #1
tandrii(chromium)
lgtm
5 years ago (2015-12-23 12:33:15 UTC) #2
Daniel Bratell
On 2015/12/23 12:33:15, tandrii(chromium) wrote: > lgtm Thanks! I'm waiting to give dpranke a chance ...
5 years ago (2015-12-23 14:58:14 UTC) #3
Dirk Pranke
lgtm
5 years ago (2015-12-23 18:17:19 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1545913002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1545913002/1
5 years ago (2015-12-23 18:26:46 UTC) #6
commit-bot: I haz the power
5 years ago (2015-12-23 18:28:18 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=298097

Powered by Google App Engine
This is Rietveld 408576698