Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1545893003:
sdf: use linear edge distance approximation for all gradient directions (Closed)
Descriptionsdf: use linear edge distance approximation for all gradient directions
Image diff tools tell me there are diffs, but I sure can't see them.
This drops edge_distance() off the chart as far as CPU cost goes.
BUG=skia:4729
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1545893003
Committed: https://skia.googlesource.com/skia/+/8a87bb4d5c23da83ef406ef87b470afa4217d7a4
Patch Set 1 #
Messages
Total messages: 21 (10 generated)
Description was changed from ========== sdf: use linear edge distance approximation for all gradient directions Image diff tools tell me there are diffs, but I sure can't see them. This drops edge_distance() off the chart as far as CPU cost goes. BUG=skia: ========== to ========== sdf: use linear edge distance approximation for all gradient directions Image diff tools tell me there are diffs, but I sure can't see them. This drops edge_distance() off the chart as far as CPU cost goes. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... ==========
The CQ bit was checked by mtklein@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1545893003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1545893003/1
The CQ bit was unchecked by mtklein@chromium.org
Description was changed from ========== sdf: use linear edge distance approximation for all gradient directions Image diff tools tell me there are diffs, but I sure can't see them. This drops edge_distance() off the chart as far as CPU cost goes. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... ========== to ========== sdf: use linear edge distance approximation for all gradient directions Image diff tools tell me there are diffs, but I sure can't see them. This drops edge_distance() off the chart as far as CPU cost goes. BUG=skia:4729 GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... ==========
The CQ bit was checked by mtklein@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1545893003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1545893003/1
mtklein@chromium.org changed reviewers: + jvanverth@google.com
Whoops, I'm not sure why I never sent this out.
The CQ bit was unchecked by commit-bot@chromium.org
On 2016/01/19 20:21:14, mtklein_C wrote: > Whoops, I'm not sure why I never sent this out. I guess this is okay (particularly since Gustavson says it's a reasonable approximation). Just going to put my flag in the sand (and mix my metaphors) and say I'm glad you left the old code in just in case. lgtm
Dry run: This issue passed the CQ dry run.
On 2016/01/19 20:32:41, jvanverth1 wrote: > On 2016/01/19 20:21:14, mtklein_C wrote: > > Whoops, I'm not sure why I never sent this out. > > I guess this is okay (particularly since Gustavson says it's a reasonable > approximation). Just going to put my flag in the sand (and mix my metaphors) and > say I'm glad you left the old code in just in case. > > lgtm Me too. I can't remember... if we stick to this approximation, does that mean we don't need to store the gradient any more, or do we still need that for other reasons?
The CQ bit was checked by mtklein@google.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1545893003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1545893003/1
Message was sent while issue was closed.
Description was changed from ========== sdf: use linear edge distance approximation for all gradient directions Image diff tools tell me there are diffs, but I sure can't see them. This drops edge_distance() off the chart as far as CPU cost goes. BUG=skia:4729 GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... ========== to ========== sdf: use linear edge distance approximation for all gradient directions Image diff tools tell me there are diffs, but I sure can't see them. This drops edge_distance() off the chart as far as CPU cost goes. BUG=skia:4729 GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... Committed: https://skia.googlesource.com/skia/+/8a87bb4d5c23da83ef406ef87b470afa4217d7a4 ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://skia.googlesource.com/skia/+/8a87bb4d5c23da83ef406ef87b470afa4217d7a4
Message was sent while issue was closed.
On 2016/01/19 20:34:30, mtklein wrote: > On 2016/01/19 20:32:41, jvanverth1 wrote: > > On 2016/01/19 20:21:14, mtklein_C wrote: > > > Whoops, I'm not sure why I never sent this out. > > > > I guess this is okay (particularly since Gustavson says it's a reasonable > > approximation). Just going to put my flag in the sand (and mix my metaphors) > and > > say I'm glad you left the old code in just in case. > > > > lgtm > > Me too. > > I can't remember... if we stick to this approximation, does that mean we don't > need to store the gradient any more, or do we still need that for other reasons? It takes the gradient, normalizes it, then scales it by the squared distance to get an approximate vector to the closest edge (by squared distance). This last thing is used to do the updates. So yes, we still need to calculate it.
Message was sent while issue was closed.
reed@google.com changed reviewers: + bsalomon@google.com, reed@google.com
Message was sent while issue was closed.
Is this change triggering the layout failure in the DEPS roll?
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/1603953005/ by mtklein@google.com. The reason for reverting is: breaks roll? https://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/.... |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
