Fix 'illegal access' in Date constructor edge case

src/js/macros.py

Index: src/js/macros.py
diff --git a/src/js/macros.py b/src/js/macros.py
index d92e2acc76677fce9b16bb27e7d608a9220668db..c1fe81b1b2218ba813482a17b181b9b6290cd502 100644
--- a/src/js/macros.py
+++ b/src/js/macros.py
@@ -191,7 +191,7 @@ macro NUMBER_OF_CAPTURES(array) = ((array)[0]);
 # Limit according to ECMA 262 15.9.1.1
 define MAX_TIME_MS = 8640000000000000;
 # Limit which is MAX_TIME_MS + msPerMonth.

[Camillo Bruni, 2015/12/23 14:46:08]

Please update the comment.

[Dan Ehrenberg, 2015/12/25 01:00:49]

Following more investigation, I decided to keep the JS how it was (test262 tests
seem to verify this particular threshold) and update the C++ side, so this
comment is accurate again.

-define MAX_TIME_BEFORE_UTC = 8640002592000000;
+define MAX_TIME_BEFORE_UTC = 8640000000000000;

[Camillo Bruni, 2015/12/23 14:46:08]

DateCache::kMaxTimeBeforeUTCInMs is 
8640000864000000, you set it to
8640000000000000, and previously it was
8640002592000000, so to me that does not clear the inconsistency :P it just puts
us on the safe side.

Could we add a cctest to somehow ensure that these constants are in sync?

[Dan Ehrenberg, 2015/12/25 01:00:49]

Oops, you're right. But do you have a good idea for how to write a test which
gets at both a C++ constant and a macro (when the macro expansion system is
written in Python)?

 
 # Gets the value of a Date object. If arg is not a Date object
 # a type error is thrown.