Fix 'illegal access' in Date constructor edge case

src/js/macros.py

 # Copyright 2006-2009 the V8 project authors. All rights reserved.
 # Redistribution and use in source and binary forms, with or without
 # modification, are permitted provided that the following conditions are
 # met:
 #
 #     * Redistributions of source code must retain the above copyright
 #       notice, this list of conditions and the following disclaimer.
 #     * Redistributions in binary form must reproduce the above
 #       copyright notice, this list of conditions and the following
 #       disclaimer in the documentation and/or other materials provided
@@ skipping 172 matching lines @@
 macro REGEXP_STICKY(regexp) = (%_RegExpFlags(regexp) & 8);
 macro REGEXP_UNICODE(regexp) = (%_RegExpFlags(regexp) & 16);
 macro REGEXP_SOURCE(regexp) = (%_RegExpSource(regexp));
 
 # We can't put macros in macros so we use constants here.
 # REGEXP_NUMBER_OF_CAPTURES
 macro NUMBER_OF_CAPTURES(array) = ((array)[0]);
 
 # Limit according to ECMA 262 15.9.1.1
 define MAX_TIME_MS = 8640000000000000;
 # Limit which is MAX_TIME_MS + msPerMonth.

[Camillo Bruni, 2015/12/23 14:46:08]

Please update the comment.

[Dan Ehrenberg, 2015/12/25 01:00:49]

Following more investigation, I decided to keep the JS how it was (test262 tests
seem to verify this particular threshold) and update the C++ side, so this
comment is accurate again.

-define MAX_TIME_BEFORE_UTC = 8640002592000000;
+define MAX_TIME_BEFORE_UTC = 8640000000000000;

[Camillo Bruni, 2015/12/23 14:46:08]

DateCache::kMaxTimeBeforeUTCInMs is 
8640000864000000, you set it to
8640000000000000, and previously it was
8640002592000000, so to me that does not clear the inconsistency :P it just puts
us on the safe side.

Could we add a cctest to somehow ensure that these constants are in sync?

[Dan Ehrenberg, 2015/12/25 01:00:49]

Oops, you're right. But do you have a good idea for how to write a test which
gets at both a C++ constant and a macro (when the macro expansion system is
written in Python)?

 
 # Gets the value of a Date object. If arg is not a Date object
 # a type error is thrown.
 macro CHECK_DATE(arg) = if (!%_IsDate(arg)) %_ThrowNotDateError();
 macro LOCAL_DATE_VALUE(arg) = (%_DateField(arg, 0) + %_DateField(arg, 21));
 macro UTC_DATE_VALUE(arg)    = (%_DateField(arg, 0));
 
 macro LOCAL_YEAR(arg)        = (%_DateField(arg, 1));
 macro LOCAL_MONTH(arg)       = (%_DateField(arg, 2));
 macro LOCAL_DAY(arg)         = (%_DateField(arg, 3));
@@ skipping 102 matching lines @@
 # Must match OrderedHashTable::kNotFound.
 define NOT_FOUND = -1;
 
 # Check whether debug is active.
 define DEBUG_IS_ACTIVE = (%_DebugIsActive() != 0);
 macro DEBUG_PREPARE_STEP_IN_IF_STEPPING(function) = if (%_DebugIsActive() != 0) %DebugPrepareStepInIfStepping(function);
 
 # SharedFlag equivalents
 define kNotShared = false;
 define kShared = true;