Chromium Code Reviews| Index: third_party/WebKit/Source/core/dom/IntersectionObserverController.cpp |
| diff --git a/third_party/WebKit/Source/core/dom/IntersectionObserverController.cpp b/third_party/WebKit/Source/core/dom/IntersectionObserverController.cpp |
| index af28fdd7d1cf5aa776fcea7d11e44db93cc11061..24fdcaaf5e51992d157bff0474ea027a793bb872 100644 |
| --- a/third_party/WebKit/Source/core/dom/IntersectionObserverController.cpp |
| +++ b/third_party/WebKit/Source/core/dom/IntersectionObserverController.cpp |
| @@ -19,7 +19,9 @@ IntersectionObserverController::~IntersectionObserverController() { } |
| void IntersectionObserverController::scheduleIntersectionObserverForDelivery(IntersectionObserver& observer) |
| { |
| - // TODO(szager): use idle callback with a timeout |
| + // TODO(szager): use idle callback with a timeout. Until we do that, there is no |
| + // reliable way to write a test for takeRecords, because it's impossible to guarantee |
| + // that javascript will get a chance to run before the timer fires. |
|
ojan
2016/01/12 00:43:05
As per in person discussion, not quite clear if th
|
| if (!m_timer.isActive()) |
| m_timer.startOneShot(0, BLINK_FROM_HERE); |
| m_pendingIntersectionObservers.add(&observer); |