Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(93)

Issue 1545813002: Remove unnecessary RAF from tests. (Closed)

Created:
5 years ago by szager1
Modified:
4 years, 11 months ago
Reviewers:
esprehn, ojan
CC:
blink-reviews, blink-reviews-dom_chromium.org, chromium-reviews, dglazkov+blink, eae+blinkwatch, rwlbuis, sof
Base URL:
https://chromium.googlesource.com/chromium/src@intersection-observer-document-root
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove unnecessary RAF from tests. BUG=540528 R=ojan@chromium.org,esprehn@chromium.org Committed: https://crrev.com/ae74c45ad305c6bb5317dd4f646279aa704e46d9 Cr-Commit-Position: refs/heads/master@{#369060}

Patch Set 1 #

Patch Set 2 : rebaseline #

Total comments: 1

Patch Set 3 : rebaseline #

Messages

Total messages: 13 (5 generated)
szager1
5 years ago (2015-12-22 22:50:25 UTC) #1
szager1
ping
4 years, 11 months ago (2016-01-08 23:54:27 UTC) #2
ojan
lgtm https://codereview.chromium.org/1545813002/diff/20001/third_party/WebKit/Source/core/dom/IntersectionObserverController.cpp File third_party/WebKit/Source/core/dom/IntersectionObserverController.cpp (right): https://codereview.chromium.org/1545813002/diff/20001/third_party/WebKit/Source/core/dom/IntersectionObserverController.cpp#newcode24 third_party/WebKit/Source/core/dom/IntersectionObserverController.cpp:24: // that javascript will get a chance to ...
4 years, 11 months ago (2016-01-12 00:43:05 UTC) #3
szager1
On 2016/01/12 00:43:05, ojan wrote: > lgtm > > https://codereview.chromium.org/1545813002/diff/20001/third_party/WebKit/Source/core/dom/IntersectionObserverController.cpp > File third_party/WebKit/Source/core/dom/IntersectionObserverController.cpp > (right): ...
4 years, 11 months ago (2016-01-12 01:06:05 UTC) #4
commit-bot: I haz the power
This CL has an open dependency (Issue 1559593002 Patch 20001). Please resolve the dependency and ...
4 years, 11 months ago (2016-01-12 01:08:43 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1545813002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1545813002/40001
4 years, 11 months ago (2016-01-12 23:11:23 UTC) #10
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 11 months ago (2016-01-13 01:00:35 UTC) #11
commit-bot: I haz the power
4 years, 11 months ago (2016-01-13 01:02:33 UTC) #13
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/ae74c45ad305c6bb5317dd4f646279aa704e46d9
Cr-Commit-Position: refs/heads/master@{#369060}

Powered by Google App Engine
This is Rietveld 408576698