Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(833)

Unified Diff: chrome/browser/usb/usb_chooser_bubble_delegate.h

Issue 1545773002: Address some TODOs for ChooserBubbleDelegate class (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: updated comments Created 4 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/usb/usb_chooser_bubble_delegate.h
diff --git a/chrome/browser/usb/usb_chooser_bubble_delegate.h b/chrome/browser/usb/usb_chooser_bubble_delegate.h
index 6d47134195e5f60e0c9caa3133517368fa029786..af4526b162b7f6f66d28043e5f40cf1d4dba4af5 100644
--- a/chrome/browser/usb/usb_chooser_bubble_delegate.h
+++ b/chrome/browser/usb/usb_chooser_bubble_delegate.h
@@ -5,6 +5,8 @@
#ifndef CHROME_BROWSER_USB_USB_CHOOSER_BUBBLE_DELEGATE_H_
#define CHROME_BROWSER_USB_USB_CHOOSER_BUBBLE_DELEGATE_H_
+#include <utility>
+
#include "base/macros.h"
#include "base/memory/ref_counted.h"
#include "base/memory/weak_ptr.h"
@@ -38,8 +40,9 @@ class UsbChooserBubbleDelegate : public ChooserBubbleDelegate,
~UsbChooserBubbleDelegate() override;
// ChooserBubbleDelegate:
- const std::vector<base::string16>& GetOptions() const override;
- void Select(int index) override;
+ size_t NumOptions() const override;
+ const base::string16& GetOption(size_t index) const override;
+ void Select(size_t index) override;
void Cancel() override;
void Close() override;
@@ -58,8 +61,9 @@ class UsbChooserBubbleDelegate : public ChooserBubbleDelegate,
ScopedObserver<device::UsbService, device::UsbService::Observer>
usb_service_observer_;
std::vector<device::UsbDeviceFilter> filters_;
- std::vector<scoped_refptr<device::UsbDevice>> devices_;
- std::vector<base::string16> devices_names_;
+ // Each pair is a (device, device name).
+ std::vector<std::pair<scoped_refptr<device::UsbDevice>, base::string16>>
+ devices_;
BubbleReference bubble_controller_;
base::WeakPtrFactory<UsbChooserBubbleDelegate> weak_factory_;
« no previous file with comments | « chrome/browser/ui/website_settings/chooser_bubble_delegate.h ('k') | chrome/browser/usb/usb_chooser_bubble_delegate.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698