chrome/browser/ui/cocoa/website_settings/chooser_bubble_ui_cocoa.h - Issue 1545773002: Address some TODOs for ChooserBubbleDelegate class

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/website_settings/chooser_bubble_ui_cocoa.h

Issue 1545773002: Address some TODOs for ChooserBubbleDelegate class (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: updated comments Created 4 years, 12 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/cocoa/website_settings/chooser_bubble_ui_cocoa.h

diff --git a/chrome/browser/ui/cocoa/website_settings/chooser_bubble_ui_cocoa.h b/chrome/browser/ui/cocoa/website_settings/chooser_bubble_ui_cocoa.h

index 8be15bd977fa77ae4e82b327fc34fbe186c55a4f..f7427543cd165ee96f8a5ce83931e790a7ea2b4c 100644

--- a/chrome/browser/ui/cocoa/website_settings/chooser_bubble_ui_cocoa.h

+++ b/chrome/browser/ui/cocoa/website_settings/chooser_bubble_ui_cocoa.h

@@ -32,8 +32,8 @@ class ChooserBubbleUiCocoa : public BubbleUi,

// ChooserBubbleDelegate::Observer:

void OnOptionsInitialized() override;

- void OnOptionAdded(int index) override;

- void OnOptionRemoved(int index) override;

+ void OnOptionAdded(size_t index) override;

+ void OnOptionRemoved(size_t index) override;

// Called when |chooser_bubble_ui_controller_| is closing.

void OnBubbleClosing();