Address some TODOs for ChooserBubbleDelegate class

chrome/browser/ui/views/website_settings/chooser_bubble_ui_view.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/views/website_settings/chooser_bubble_ui_view.h"
 
+#include <algorithm>
 #include <string>
 
 #include "base/macros.h"
 #include "base/prefs/pref_service.h"
 #include "base/strings/string16.h"
 #include "chrome/browser/profiles/profile.h"
 #include "chrome/browser/ui/browser.h"
 #include "chrome/browser/ui/views/exclusive_access_bubble_views.h"
 #include "chrome/browser/ui/views/frame/browser_view.h"
 #include "chrome/browser/ui/views/frame/top_container_view.h"
@@ skipping 91 matching lines @@
 ui::TableColumn ChooserTableColumn(int id, const std::string& title) {
   ui::TableColumn column;
   column.id = id;
   column.title = base::ASCIIToUTF16(title.c_str());
   return column;
 }
 
 class ChooserTableModel : public ui::TableModel,
                           public ChooserBubbleDelegate::Observer {
  public:
-  explicit ChooserTableModel(ChooserBubbleDelegate* chooser_bubble_delegate)
-      : observer_(nullptr), chooser_bubble_delegate_(chooser_bubble_delegate) {
-    chooser_bubble_delegate_->set_observer(this);
-  }
+  explicit ChooserTableModel(ChooserBubbleDelegate* chooser_bubble_delegate);
 
   // ui::TableModel:
-  int RowCount() override {
-    const std::vector<base::string16>& device_names =
-        chooser_bubble_delegate_->GetOptions();
-    if (device_names.empty()) {
-      // Here it returns 1 when there is no device. In this case, the
-      // table view still needs to display a text message saying no
-      // devices found, so the number of rows is 1.
-      return 1;
-    } else {
-      return static_cast<int>(device_names.size());
-    }
-  }
+  int RowCount() override;
+  base::string16 GetText(int row, int column_id) override;
+  void SetObserver(ui::TableModelObserver* observer) override;
 
-  // ui::TableModel:
-  base::string16 GetText(int row, int column_id) override {
-    const std::vector<base::string16>& device_names =
-        chooser_bubble_delegate_->GetOptions();
-    if (device_names.empty()) {
-      DCHECK(row == 0);
-      return l10n_util::GetStringUTF16(
-          IDS_CHOOSER_BUBBLE_NO_DEVICES_FOUND_PROMPT);
-    } else if (row >= 0 && row < static_cast<int>(device_names.size())) {
-      return device_names[row];
-    } else {
-      NOTREACHED();
-      return base::string16();
-    }
-  }
+  // ChooserBubbleDelegate::Observer:
+  void OnOptionsInitialized() override;
+  void OnOptionAdded(size_t index) override;
+  void OnOptionRemoved(size_t index) override;
 
-  // ui::TableModel:
-  void SetObserver(ui::TableModelObserver* observer) override {
-    observer_ = observer;
-  }
-
-  // ChooserOptions::Observer:
-  void OnOptionsInitialized() override {
-    if (observer_) {
-      observer_->OnModelChanged();
-      Update();
-    }
-  }
-
-  // ChooserOptions::Observer:
-  void OnOptionAdded(int index) override {
-    if (observer_) {
-      observer_->OnItemsAdded(index, 1);
-      Update();
-    }
-  }
-
-  // ChooserOptions::Observer:
-  void OnOptionRemoved(int index) override {
-    if (observer_) {
-      observer_->OnItemsRemoved(index, 1);
-      Update();
-    }
-  }
-
-  void Update() {
-    views::TableView* table_view = static_cast<views::TableView*>(observer_);
-
-    if (chooser_bubble_delegate_->GetOptions().empty()) {
-      observer_->OnModelChanged();
-      table_view->SetEnabled(false);
-    } else {
-      table_view->SetEnabled(true);
-    }
-  }
-
-  void SetConnectButton(views::LabelButton* connect_button) {
-    connect_button_ = connect_button;
-  }
+  void Update();
+  void SetConnectButton(views::LabelButton* connect_button);
 
  private:
   ui::TableModelObserver* observer_;
   ChooserBubbleDelegate* chooser_bubble_delegate_;
   views::LabelButton* connect_button_;
 };
 
 ChooserBubbleUiViewDelegate::ChooserBubbleUiViewDelegate(
     views::View* anchor_view,
     views::BubbleBorder::Arrow anchor_arrow,
@@ skipping 19 matching lines @@
   chooser_table_model_ = new ChooserTableModel(chooser_bubble_delegate_);
   table_view_ = new views::TableView(chooser_table_model_, table_columns,
                                      views::TEXT_ONLY, true);
   table_view_->set_select_on_remove(false);
   chooser_table_model_->SetObserver(table_view_);
   table_view_->SetObserver(this);
   layout->AddView(table_view_->CreateParentIfNecessary(), 1, 1,
                   views::GridLayout::FILL, views::GridLayout::FILL,
                   kChooserPermissionBubbleWidth,
                   kChooserPermissionBubbleHeight);
-  if (chooser_bubble_delegate_->GetOptions().empty()) {
+  if (chooser_bubble_delegate_->NumOptions() == 0) {
     table_view_->SetEnabled(false);
   }
 
   layout->AddPaddingRow(0, kItemMajorSpacing);
 
   views::View* button_row = new views::View();
   views::GridLayout* button_layout = new views::GridLayout(button_row);
   views::ColumnSet* button_columns = button_layout->AddColumnSet(0);
   button_row->SetLayoutManager(button_layout);
   layout->StartRow(1, 0);
@@ skipping 91 matching lines @@
   views::BubbleBorder::Arrow adjusted_arrow = anchor_arrow;
   if (base::i18n::IsRTL())
     adjusted_arrow = views::BubbleBorder::horizontal_mirror(adjusted_arrow);
   frame->SetBubbleBorder(scoped_ptr<views::BubbleBorder>(
       new views::BubbleBorder(adjusted_arrow, shadow(), color())));
 
   // Reposition the bubble based on the updated arrow and view.
   SetAnchorView(anchor_view);
 }
 
+ChooserTableModel::ChooserTableModel(
+    ChooserBubbleDelegate* chooser_bubble_delegate)
+    : observer_(nullptr), chooser_bubble_delegate_(chooser_bubble_delegate) {
+  chooser_bubble_delegate_->set_observer(this);
+}
+
+int ChooserTableModel::RowCount() {
+  // When there are no devices, the table contains a message saying there
+  // are no devices, so the number of rows is always at least 1.
+  return std::max(static_cast<int>(chooser_bubble_delegate_->NumOptions()), 1);
+}
+
+base::string16 ChooserTableModel::GetText(int row, int column_id) {
+  int num_options = static_cast<int>(chooser_bubble_delegate_->NumOptions());
+  if (num_options == 0) {
+    DCHECK_EQ(0, row);
+    return l10n_util::GetStringUTF16(
+        IDS_CHOOSER_BUBBLE_NO_DEVICES_FOUND_PROMPT);
+  }
+
+  DCHECK_GE(row, 0);
+  DCHECK_LT(row, num_options);
+  return chooser_bubble_delegate_->GetOption(static_cast<size_t>(row));
+}
+
+void ChooserTableModel::SetObserver(ui::TableModelObserver* observer) {
+  observer_ = observer;
+}
+
+void ChooserTableModel::OnOptionsInitialized() {
+  if (observer_) {
+    observer_->OnModelChanged();
+    Update();
+  }
+}
+
+void ChooserTableModel::OnOptionAdded(size_t index) {
+  if (observer_) {
+    observer_->OnItemsAdded(static_cast<int>(index), 1);
+    Update();
+  }
+}
+
+void ChooserTableModel::OnOptionRemoved(size_t index) {
+  if (observer_) {
+    observer_->OnItemsRemoved(static_cast<int>(index), 1);
+    Update();
+  }
+}
+
+void ChooserTableModel::Update() {
+  views::TableView* table_view = static_cast<views::TableView*>(observer_);
+
+  if (chooser_bubble_delegate_->NumOptions() == 0) {
+    observer_->OnModelChanged();
+    table_view->SetEnabled(false);
+  } else {
+    table_view->SetEnabled(true);
+  }
+}
+
+void ChooserTableModel::SetConnectButton(views::LabelButton* connect_button) {
+  connect_button_ = connect_button;
+}
+
 //////////////////////////////////////////////////////////////////////////////
 // ChooserBubbleUiView
 
 ChooserBubbleUiView::ChooserBubbleUiView(
     Browser* browser,
     ChooserBubbleDelegate* chooser_bubble_delegate)
     : browser_(browser),
       chooser_bubble_delegate_(chooser_bubble_delegate),
       chooser_bubble_ui_view_delegate_(nullptr) {
   DCHECK(browser_);
@@ skipping 41 matching lines @@
     return browser_view->exclusive_access_bubble()->GetView();
 
   return browser_view->top_container();
 }
 
 views::BubbleBorder::Arrow ChooserBubbleUiView::GetAnchorArrow() {
   if (browser_->SupportsWindowFeature(Browser::FEATURE_LOCATIONBAR))
     return views::BubbleBorder::TOP_LEFT;
   return views::BubbleBorder::NONE;
 }