Move ownership of Transport out of Session.

remoting/protocol/session.h

Index: remoting/protocol/session.h
diff --git a/remoting/protocol/session.h b/remoting/protocol/session.h
index fb462e0a1f0b36921fcc1122cfb3e7448e2068dc..2df3f20a8e8ee8c027529e76cf23fbf51117f489 100644
--- a/remoting/protocol/session.h
+++ b/remoting/protocol/session.h
@@ -9,17 +9,23 @@
 
 #include "remoting/protocol/errors.h"
 #include "remoting/protocol/session_config.h"
+#include "remoting/protocol/transport.h"
+
+namespace buzz {
+class XmlElement;
+}  // namespace buzz
 
 namespace remoting {
 namespace protocol {
 
+class Authenicator;
 class StreamChannelFactory;
 class Transport;
 struct TransportRoute;
 
-// Generic interface for Chromotocol connection used by both client and host.
-// Provides access to the connection channels, but doesn't depend on the
-// protocol used for each channel.
+// Session is responsible for initializing and authenticating both incoming and
+// outgoing connections. It uses TransportInfoSink interface to pass
+// transport-info messages to the transport.
 class Session {
  public:
   enum State {
@@ -41,9 +47,6 @@ class Session {
     // Session has been connected and authenticated.
     AUTHENTICATED,
 
-    // Session has been connected.
-    CONNECTED,

[Jamie, 2015/12/24 15:03:18]

Removing the CONNECTED state seems like a big enough change to warrant inclusion
in the CL description.

[Sergey Ulanov, 2015/12/28 18:58:50]

Done

-
     // Session has been closed.
     CLOSED,
 
@@ -60,12 +63,6 @@ class Session {
     // the session from within the handler if |state| is AUTHENTICATING
     // or CLOSED or FAILED.
     virtual void OnSessionStateChange(State state) = 0;
-
-    // Called whenever route for the channel specified with
-    // |channel_name| changes. Session must not be destroyed by the
-    // handler of this event.
-    virtual void OnSessionRouteChange(const std::string& channel_name,
-                                      const TransportRoute& route) = 0;
   };
 
   Session() {}
@@ -85,10 +82,11 @@ class Session {
   // Returned pointer is valid until connection is closed.
   virtual const SessionConfig& config() = 0;
 
-  // Returns Transport that can be used to create transport channels.
-  virtual Transport* GetTransport() = 0;
+  // Sets Transport to be used by the session. Must be called before the
+  // session becomes AUTHENTICATED. The transport must outlive the session.
+  virtual void SetTransport(Transport* transport) = 0;
 
-  // Closes connection. Callbacks are guaranteed not to be called after this
+  // Closes connection. EventHandler is guaranteed not to be called after this
   // method returns. |error| specifies the error code in case when the session
   // is being closed due to an error.
   virtual void Close(ErrorCode error) = 0;