Move ownership of Transport out of Session.

Move ownership of Transport out of Session.

Previously Session implementations were responsible for creation and
ownership of Transport objects. Now Connection* classes own both
Transport and Session instances. This allows to ensure that correct
type of transport is created (i.e. WebRTC connection uses
WebrtcTransport). It also makes it possible for the host to support
two types of connections similtaneously (previously Ice connections
were not working when the host was started with --enable-webrtc).

Session is no longer responsible for tracking state of the Transport,
so it doesn't need CONNECTED state anymore. Session just passes
transport-info messages to and from transport and the Connection
object is responsible for tracking the state of the transport.

BUG=547158
Committed: https://crrev.com/e57676028aa68166bcffa1f234ec8770a4d73e8a
Cr-Commit-Position: refs/heads/master@{#367003}

[Sergey Ulanov, 2015-12-22 18:24:19]

Description was changed from

==========
Move ownership of Transport out of Session.

Previously Session implementations were responsible for creation and
ownership of Transport objects. Now Connection* classes own both
Transport and Session instances. This allows to ensure that correct
type of transport is created (i.e. WebRTC connection uses
WebrtcTransport). It also makes it possible for the host to support
two types of connections similtaneously (previously Ice connections
were not working when the host was started with --enable-webrtc).
==========

to

==========
Move ownership of Transport out of Session.

Previously Session implementations were responsible for creation and
ownership of Transport objects. Now Connection* classes own both
Transport and Session instances. This allows to ensure that correct
type of transport is created (i.e. WebRTC connection uses
WebrtcTransport). It also makes it possible for the host to support
two types of connections similtaneously (previously Ice connections
were not working when the host was started with --enable-webrtc).

BUG=547158
==========

[Sergey Ulanov, 2015-12-22 18:24:22]

sergeyu@chromium.org changed reviewers:
+ jamiewalch@chromium.org

[Jamie, 2015-12-24 15:03:18]

lgtm

https://codereview.chromium.org/1545743002/diff/1/remoting/protocol/session.h
File remoting/protocol/session.h (left):

https://codereview.chromium.org/1545743002/diff/1/remoting/protocol/session.h...
remoting/protocol/session.h:45: CONNECTED,
Removing the CONNECTED state seems like a big enough change to warrant inclusion
in the CL description.

[Sergey Ulanov, 2015-12-28 18:58:33]

Description was changed from

==========
Move ownership of Transport out of Session.

Previously Session implementations were responsible for creation and
ownership of Transport objects. Now Connection* classes own both
Transport and Session instances. This allows to ensure that correct
type of transport is created (i.e. WebRTC connection uses
WebrtcTransport). It also makes it possible for the host to support
two types of connections similtaneously (previously Ice connections
were not working when the host was started with --enable-webrtc).

BUG=547158
==========

to

==========
Move ownership of Transport out of Session.

Previously Session implementations were responsible for creation and
ownership of Transport objects. Now Connection* classes own both
Transport and Session instances. This allows to ensure that correct
type of transport is created (i.e. WebRTC connection uses
WebrtcTransport). It also makes it possible for the host to support
two types of connections similtaneously (previously Ice connections
were not working when the host was started with --enable-webrtc).

Session is no longer responsible for tracking state of the Transport,
so it doesn't need CONNECTED state anymore. Session just passes
transport-info messages to and from transport and the Connection
object is responsible for tracking the state of the transport.

BUG=547158
==========

[Sergey Ulanov, 2015-12-28 18:58:50]

https://codereview.chromium.org/1545743002/diff/1/remoting/protocol/session.h
File remoting/protocol/session.h (left):

https://codereview.chromium.org/1545743002/diff/1/remoting/protocol/session.h...
remoting/protocol/session.h:45: CONNECTED,
On 2015/12/24 15:03:18, Jamie wrote:
> Removing the CONNECTED state seems like a big enough change to warrant
inclusion
> in the CL description.

Done

[Sergey Ulanov, 2015-12-28 18:59:38]

The CQ bit was checked by sergeyu@chromium.org

[commit-bot: I haz the power, 2015-12-28 19:00:04]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1545743002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1545743002/1

[commit-bot: I haz the power, 2015-12-28 19:03:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-12-28 19:03:05]

Try jobs failed on following builders:
  android_arm64_dbg_recipe on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)
  android_chromium_gn_compile_dbg on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_chro...)
  android_chromium_gn_compile_rel on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_chro...)
  android_compile_dbg on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)
  cast_shell_linux on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)
  linux_chromium_chromeos_ozone_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_clobber_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_compile_dbg_32_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_gn_chromeos_rel on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)
  ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ni...)
  mac_chromium_gn_rel on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gn_r...)
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Sergey Ulanov, 2015-12-28 19:16:22]

The CQ bit was checked by sergeyu@chromium.org

[Sergey Ulanov, 2015-12-28 19:16:23]

The patchset sent to the CQ was uploaded after l-g-t-m from
jamiewalch@chromium.org
Link to the patchset: https://codereview.chromium.org/1545743002/#ps20001
(title: " ")

[commit-bot: I haz the power, 2015-12-28 19:16:34]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1545743002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1545743002/20001

[commit-bot: I haz the power, 2015-12-28 19:49:10]

Description was changed from

==========
Move ownership of Transport out of Session.

Previously Session implementations were responsible for creation and
ownership of Transport objects. Now Connection* classes own both
Transport and Session instances. This allows to ensure that correct
type of transport is created (i.e. WebRTC connection uses
WebrtcTransport). It also makes it possible for the host to support
two types of connections similtaneously (previously Ice connections
were not working when the host was started with --enable-webrtc).

Session is no longer responsible for tracking state of the Transport,
so it doesn't need CONNECTED state anymore. Session just passes
transport-info messages to and from transport and the Connection
object is responsible for tracking the state of the transport.

BUG=547158
==========

to

==========
Move ownership of Transport out of Session.

Previously Session implementations were responsible for creation and
ownership of Transport objects. Now Connection* classes own both
Transport and Session instances. This allows to ensure that correct
type of transport is created (i.e. WebRTC connection uses
WebrtcTransport). It also makes it possible for the host to support
two types of connections similtaneously (previously Ice connections
were not working when the host was started with --enable-webrtc).

Session is no longer responsible for tracking state of the Transport,
so it doesn't need CONNECTED state anymore. Session just passes
transport-info messages to and from transport and the Connection
object is responsible for tracking the state of the transport.

BUG=547158
==========

[commit-bot: I haz the power, 2015-12-28 19:49:10]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-12-28 19:50:10]

Description was changed from

==========
Move ownership of Transport out of Session.

Previously Session implementations were responsible for creation and
ownership of Transport objects. Now Connection* classes own both
Transport and Session instances. This allows to ensure that correct
type of transport is created (i.e. WebRTC connection uses
WebrtcTransport). It also makes it possible for the host to support
two types of connections similtaneously (previously Ice connections
were not working when the host was started with --enable-webrtc).

Session is no longer responsible for tracking state of the Transport,
so it doesn't need CONNECTED state anymore. Session just passes
transport-info messages to and from transport and the Connection
object is responsible for tracking the state of the transport.

BUG=547158
==========

to

==========
Move ownership of Transport out of Session.

Previously Session implementations were responsible for creation and
ownership of Transport objects. Now Connection* classes own both
Transport and Session instances. This allows to ensure that correct
type of transport is created (i.e. WebRTC connection uses
WebrtcTransport). It also makes it possible for the host to support
two types of connections similtaneously (previously Ice connections
were not working when the host was started with --enable-webrtc).

Session is no longer responsible for tracking state of the Transport,
so it doesn't need CONNECTED state anymore. Session just passes
transport-info messages to and from transport and the Connection
object is responsible for tracking the state of the transport.

BUG=547158

Committed: https://crrev.com/e57676028aa68166bcffa1f234ec8770a4d73e8a
Cr-Commit-Position: refs/heads/master@{#367003}
==========

[commit-bot: I haz the power, 2015-12-28 19:50:11]

Patchset 2 (id:??) landed as
https://crrev.com/e57676028aa68166bcffa1f234ec8770a4d73e8a
Cr-Commit-Position: refs/heads/master@{#367003}

[Nico, 2015-12-29 03:31:02]

On 2015/12/28 19:50:11, commit-bot: I haz the power wrote:
> Patchset 2 (id:??) landed as
> https://crrev.com/e57676028aa68166bcffa1f234ec8770a4d73e8a
> Cr-Commit-Position: refs/heads/master@{#367003}

This might have broken tests in official builds:
http://build.chromium.org/p/chromium.fyi