Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(75)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 154573003: Update remaining references to the NPAPI test plugin. (Closed)

Created:
6 years, 10 months ago by tfarina
Modified:
6 years, 10 months ago
CC:
chromium-reviews, extensions-reviews_chromium.org, jam, joi+watch-content_chromium.org, darin-cc_chromium.org, chromium-apps-reviews_chromium.org, jochen+watch_chromium.org
Visibility:
Public.

Description

Update remaining references to the NPAPI test plugin. This should fix all the references to TestNetscapePlugIn and blink_test_plugin.gyp:blink_test_plugin. BUG=331302 TEST=None R=jochen@chromium.org,mark@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=249637

Patch Set 1 #

Patch Set 2 : revert changes to chrome/test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -8 lines) Patch
M build/all.gyp View 1 3 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser_tests.isolate View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/chrome_tests.gypi View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/tools/build/win/TESTS View 1 chunk +1 line, -1 line 0 comments Download
M content/content_browsertests.isolate View 1 2 chunks +2 lines, -2 lines 0 comments Download
M content/shell/tools/plugin/mac/Info.plist View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 28 (0 generated)
tfarina
Now a complete fix... ;) Sorry for not catching this before. I forgot to grep ...
6 years, 10 months ago (2014-02-05 01:48:38 UTC) #1
jochen (gone - plz use gerrit)
lgtm
6 years, 10 months ago (2014-02-05 14:17:10 UTC) #2
Mark Mentovai
LGTM also.
6 years, 10 months ago (2014-02-05 14:49:38 UTC) #3
tfarina
The CQ bit was checked by tfarina@chromium.org
6 years, 10 months ago (2014-02-05 15:44:23 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/154573003/1
6 years, 10 months ago (2014-02-05 15:45:45 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-05 17:28:46 UTC) #6
commit-bot: I haz the power
Retried try job too often on mac_rel for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&number=221792
6 years, 10 months ago (2014-02-05 17:28:47 UTC) #7
tfarina
The CQ bit was checked by tfarina@chromium.org
6 years, 10 months ago (2014-02-05 22:49:59 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/154573003/1
6 years, 10 months ago (2014-02-05 22:51:31 UTC) #9
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-06 02:14:17 UTC) #10
commit-bot: I haz the power
Retried try job too often on mac_rel for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&number=222210
6 years, 10 months ago (2014-02-06 02:14:18 UTC) #11
tfarina
The CQ bit was checked by tfarina@chromium.org
6 years, 10 months ago (2014-02-06 12:21:23 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/154573003/1
6 years, 10 months ago (2014-02-06 12:22:15 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/154573003/1
6 years, 10 months ago (2014-02-06 13:34:59 UTC) #14
tfarina
Jochen, I need some help here. ExtensionBrowserTest.PluginPrivate is not passing.
6 years, 10 months ago (2014-02-06 16:32:52 UTC) #15
jochen (gone - plz use gerrit)
On 2014/02/06 16:32:52, tfarina wrote: > Jochen, I need some help here. > > ExtensionBrowserTest.PluginPrivate ...
6 years, 10 months ago (2014-02-06 17:07:06 UTC) #16
jochen (gone - plz use gerrit)
I'm surprised the plists have to be updated here, because the plugins are checked in ...
6 years, 10 months ago (2014-02-06 17:12:26 UTC) #17
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-06 17:14:05 UTC) #18
commit-bot: I haz the power
Retried try job too often on mac_rel for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&number=222756
6 years, 10 months ago (2014-02-06 17:14:06 UTC) #19
jochen (gone - plz use gerrit)
hum hum pretty sure that the changes below chrome/test are wrong, you shouldn't have to ...
6 years, 10 months ago (2014-02-06 17:14:09 UTC) #20
tfarina
The CQ bit was checked by tfarina@chromium.org
6 years, 10 months ago (2014-02-06 23:36:43 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/154573003/470001
6 years, 10 months ago (2014-02-06 23:38:08 UTC) #22
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-07 01:10:50 UTC) #23
commit-bot: I haz the power
Retried try job too often on linux_aura for step(s) app_list_unittests, aura_unittests, browser_tests, compositor_unittests, content_browsertests, content_unittests, ...
6 years, 10 months ago (2014-02-07 01:10:51 UTC) #24
tfarina
The CQ bit was checked by tfarina@chromium.org
6 years, 10 months ago (2014-02-07 01:13:16 UTC) #25
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/154573003/470001
6 years, 10 months ago (2014-02-07 01:15:07 UTC) #26
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/154573003/470001
6 years, 10 months ago (2014-02-07 02:23:31 UTC) #27
commit-bot: I haz the power
6 years, 10 months ago (2014-02-07 08:46:57 UTC) #28
Message was sent while issue was closed. 
Change committed as 249637

Powered by Google App Engine
This is Rietveld 408576698