Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(150)

Issue 1545703002: If the user supplied a request body in hex, print response body in hex as well. In addition, conver… (Closed)

Created:
5 years ago by Fan Yang
Modified:
4 years, 11 months ago
Reviewers:
Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@110403572
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

If the user supplied a request body in hex, print response body in hex as well. In addition, convert hex in both cases to printable ASCII characters where possible. Example output: Request: headers: { :authority:test.example.com :path:/net.grpc.examples.QuicGreeter/SayHello :scheme:http :method:POST te:trailers grpc-encoding:identity grpc-accept-encoding:identity,deflate,gzip content-type:application/grpc user-agent:grpc-c++/0.12.0.0 grpc-c/0.12.0.0 (linux) } body hex: 00000000070a05776f726c64 body ascii: . . . . . . . w o r l d Response: headers: HTTP/1.1 200 OK grpc-encoding: identity grpc-accept-encoding: identity,deflate,gzip content-type: application/grpc body hex: 0a0b48656c6c6f20776f726c64 body ascii: . . H e l l o w o r l d trailers: { grpc-status:0 } Request succeeded (200). n/a (QUIC client) Merge internal change: 110446931 R=rch@chromium.org

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+64 lines, -8 lines) Patch
M net/tools/quic/quic_client_bin.cc View 2 chunks +32 lines, -4 lines 0 comments Download
M net/tools/quic/quic_simple_client_bin.cc View 2 chunks +32 lines, -4 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 3 (1 generated)
Fan Yang
5 years ago (2015-12-22 15:38:21 UTC) #1
Ryan Hamilton
5 years ago (2015-12-22 18:22:47 UTC) #2
lgtm

Powered by Google App Engine
This is Rietveld 408576698