Inherit 'currentColor' as 'currentColor' for 'fill'/'stroke' properties

Inherit 'currentColor' as 'currentColor' for 'fill'/'stroke' properties

So this CL is that resolve something property used by `currentColor` as
the `color` property of the same element and it's inherited as
`currentColor` not as the value.

This updates the application of 'currentColor' to match the
later versions of the spec[1] which states that:

 "If the value is inherited, it’s inherited as currentcolor,
  not as the value of the color property.".

[1] https://drafts.csswg.org/css-color-4/#valdef-color-currentcolor

Because of this, the test svg/W3C-SVG-1.1-SE/color-prop-05-t.svg
will appear as a fail (but is incorrect after the spec changed.)

BUG=571723
Committed: https://crrev.com/2e92c6870ec900369b54a38e7b015e32e104dce1
Cr-Commit-Position: refs/heads/master@{#366744}

[hyunjunekim2, 2015-12-22 15:24:25]

Description was changed from

==========
Add a test for the spce changed about currentColor.

BUG=
==========

to

==========
Add a test for the spce changed about currentColor.

This also updates the application of 'currentColor' to match the later versions
of the spec[1] which states that: "If the value is inherited, it’s inherited as
currentcolor, not as the value of the color property.".

BUG=
==========

[hyunjunekim2, 2015-12-22 15:25:10]

Description was changed from

==========
Add a test for the spce changed about currentColor.

This also updates the application of 'currentColor' to match the later versions
of the spec[1] which states that: "If the value is inherited, it’s inherited as
currentcolor, not as the value of the color property.".

BUG=
==========

to

==========
Add a test for the spec[1] changed about currentColor.

"If the value is inherited, it’s inherited as currentcolor, not as the value of
the color property.".

BUG=
==========

[hyunjunekim2, 2015-12-22 15:25:34]

Description was changed from

==========
Add a test for the spec[1] changed about currentColor.

"If the value is inherited, it’s inherited as currentcolor, not as the value of
the color property.".

BUG=
==========

to

==========
Add a test for the spec[1] changed about currentColor.

"If the value is inherited, it’s inherited as currentcolor, 
not as the value of the color property.".

[1] https://drafts.csswg.org/css-color-4/#valdef-color-currentcolor

BUG=
==========

[hyunjunekim2, 2015-12-22 15:25:56]

hyunjune.kim@samsung.com changed reviewers:
+ fs@opera.com

[hyunjunekim2, 2015-12-22 15:27:26]

I split a test about currentColor.

[fs, 2015-12-22 15:33:01]

On 2015/12/22 at 15:27:26, hyunjune.kim wrote:
> I split a test about currentColor.

I think it would be better if you had the fix here as well, i.e include the
following two changes from the other CL:

https://codereview.chromium.org/1455153003/diff/520001/third_party/WebKit/Sou...
https://codereview.chromium.org/1455153003/diff/520001/third_party/WebKit/Lay...

Else, this CL will just depend on the other one - which feels a bit odd.

[hyunjunekim2, 2015-12-23 01:44:30]

hyunjune.kim@samsung.com changed reviewers:
+ pdr@chromium.org

[hyunjunekim2, 2015-12-23 01:46:55]

Description was changed from

==========
Add a test for the spec[1] changed about currentColor.

"If the value is inherited, it’s inherited as currentcolor, 
not as the value of the color property.".

[1] https://drafts.csswg.org/css-color-4/#valdef-color-currentcolor

BUG=
==========

to

==========
This also updates the application of 'currentColor' to match the
later versions of the spec[1] which states that:

 "If the value is inherited, it’s inherited as currentcolor,
  not as the value of the color property.".

[1] https://drafts.csswg.org/css-color-4/#valdef-color-currentcolor

Because of this, the test svg/W3C-SVG-1.1-SE/color-prop-05-t.svg
will appear as a fail (but is incorrect after the spec changed.)

BUG=
==========

[hyunjunekim2, 2015-12-23 01:47:41]

Description was changed from

==========
This also updates the application of 'currentColor' to match the
later versions of the spec[1] which states that:

 "If the value is inherited, it’s inherited as currentcolor,
  not as the value of the color property.".

[1] https://drafts.csswg.org/css-color-4/#valdef-color-currentcolor

Because of this, the test svg/W3C-SVG-1.1-SE/color-prop-05-t.svg
will appear as a fail (but is incorrect after the spec changed.)

BUG=
==========

to

==========
This also updates the application of 'currentColor' to match the
later versions of the spec[1] which states that:

 "If the value is inherited, it’s inherited as currentcolor,
  not as the value of the color property.".

[1] https://drafts.csswg.org/css-color-4/#valdef-color-currentcolor

Because of this, the test svg/W3C-SVG-1.1-SE/color-prop-05-t.svg
will appear as a fail (but is incorrect after the spec changed.)

BUG=537807
==========

[hyunjunekim2, 2015-12-23 01:53:43]

Description was changed from

==========
This also updates the application of 'currentColor' to match the
later versions of the spec[1] which states that:

 "If the value is inherited, it’s inherited as currentcolor,
  not as the value of the color property.".

[1] https://drafts.csswg.org/css-color-4/#valdef-color-currentcolor

Because of this, the test svg/W3C-SVG-1.1-SE/color-prop-05-t.svg
will appear as a fail (but is incorrect after the spec changed.)

BUG=537807
==========

to

==========
This also updates the application of 'currentColor' to match the
later versions of the spec[1] which states that:

 "If the value is inherited, it’s inherited as currentcolor,
  not as the value of the color property.".

[1] https://drafts.csswg.org/css-color-4/#valdef-color-currentcolor

Because of this, the test svg/W3C-SVG-1.1-SE/color-prop-05-t.svg
will appear as a fail (but is incorrect after the spec changed.)

BUG=571723, 537807
==========

[hyunjunekim2, 2015-12-23 02:28:26]

fs, Could you check PS4? Thank you. ;)

[hyunjunekim2, 2015-12-23 02:29:32]

Description was changed from

==========
This also updates the application of 'currentColor' to match the
later versions of the spec[1] which states that:

 "If the value is inherited, it’s inherited as currentcolor,
  not as the value of the color property.".

[1] https://drafts.csswg.org/css-color-4/#valdef-color-currentcolor

Because of this, the test svg/W3C-SVG-1.1-SE/color-prop-05-t.svg
will appear as a fail (but is incorrect after the spec changed.)

BUG=571723, 537807
==========

to

==========
This also updates the application of 'currentColor' to match the
later versions of the spec[1] which states that:

 "If the value is inherited, it’s inherited as currentcolor,
  not as the value of the color property.".

[1] https://drafts.csswg.org/css-color-4/#valdef-color-currentcolor

Because of this, the test svg/W3C-SVG-1.1-SE/color-prop-05-t.svg
will appear as a fail (but is incorrect after the spec changed.)

BUG=571723
==========

[fs, 2015-12-23 10:41:56]

LGTM, but please update the description and subject.

The subject should also be the first line of the description (== the actual
commit message), like so:

<subject, summary>

<longer>

I'd also suggest to not start the subject with "It's" (i.e "it" is suppose to
refer to something, which is better to spell out in this context.)

[fs, 2015-12-23 10:42:10]

Description was changed from

==========
This also updates the application of 'currentColor' to match the
later versions of the spec[1] which states that:

 "If the value is inherited, it’s inherited as currentcolor,
  not as the value of the color property.".

[1] https://drafts.csswg.org/css-color-4/#valdef-color-currentcolor

Because of this, the test svg/W3C-SVG-1.1-SE/color-prop-05-t.svg
will appear as a fail (but is incorrect after the spec changed.)

BUG=571723
==========

to

==========
This updates the application of 'currentColor' to match the
later versions of the spec[1] which states that:

 "If the value is inherited, it’s inherited as currentcolor,
  not as the value of the color property.".

[1] https://drafts.csswg.org/css-color-4/#valdef-color-currentcolor

Because of this, the test svg/W3C-SVG-1.1-SE/color-prop-05-t.svg
will appear as a fail (but is incorrect after the spec changed.)

BUG=571723
==========

[hyunjunekim2, 2015-12-23 11:30:42]

Description was changed from

==========
This updates the application of 'currentColor' to match the
later versions of the spec[1] which states that:

 "If the value is inherited, it’s inherited as currentcolor,
  not as the value of the color property.".

[1] https://drafts.csswg.org/css-color-4/#valdef-color-currentcolor

Because of this, the test svg/W3C-SVG-1.1-SE/color-prop-05-t.svg
will appear as a fail (but is incorrect after the spec changed.)

BUG=571723
==========

to

==========
This updates the application of 'currentColor' to match the
later versions of the spec[1] which states that:

 "If the value is inherited, it’s inherited as currentcolor,
  not as the value of the color property.".

[1] https://drafts.csswg.org/css-color-4/#valdef-color-currentcolor

Because of this, the test svg/W3C-SVG-1.1-SE/color-prop-05-t.svg
will appear as a fail (but is incorrect after the spec changed.)

BUG=571723
==========

[hyunjunekim2, 2015-12-23 11:40:57]

Description was changed from

==========
This updates the application of 'currentColor' to match the
later versions of the spec[1] which states that:

 "If the value is inherited, it’s inherited as currentcolor,
  not as the value of the color property.".

[1] https://drafts.csswg.org/css-color-4/#valdef-color-currentcolor

Because of this, the test svg/W3C-SVG-1.1-SE/color-prop-05-t.svg
will appear as a fail (but is incorrect after the spec changed.)

BUG=571723
==========

to

==========
Latest on the blink, paint the value inherited the color value 
of parent. But According to the specification[1] changed, this 
CL is that paint as the `color` property of the same element
and it's inherited as `currentColor` not as the value. 

This updates the application of 'currentColor' to match the
later versions of the spec[1] which states that:

 "If the value is inherited, it’s inherited as currentcolor,
  not as the value of the color property.".

[1] https://drafts.csswg.org/css-color-4/#valdef-color-currentcolor

Because of this, the test svg/W3C-SVG-1.1-SE/color-prop-05-t.svg
will appear as a fail (but is incorrect after the spec changed.)

BUG=571723
==========

[hyunjunekim2, 2015-12-23 11:43:29]

Description was changed from

==========
Latest on the blink, paint the value inherited the color value 
of parent. But According to the specification[1] changed, this 
CL is that paint as the `color` property of the same element
and it's inherited as `currentColor` not as the value. 

This updates the application of 'currentColor' to match the
later versions of the spec[1] which states that:

 "If the value is inherited, it’s inherited as currentcolor,
  not as the value of the color property.".

[1] https://drafts.csswg.org/css-color-4/#valdef-color-currentcolor

Because of this, the test svg/W3C-SVG-1.1-SE/color-prop-05-t.svg
will appear as a fail (but is incorrect after the spec changed.)

BUG=571723
==========

to

==========
Latest on the blink, paint the value inherited the color value 
of parent. But According to the specification[1] changed, this 
CL is that paint something property used by `currentColor` as
the `color` property of the same element and it's inherited as
`currentColor` not as the value. 

This updates the application of 'currentColor' to match the
later versions of the spec[1] which states that:

 "If the value is inherited, it’s inherited as currentcolor,
  not as the value of the color property.".

[1] https://drafts.csswg.org/css-color-4/#valdef-color-currentcolor

Because of this, the test svg/W3C-SVG-1.1-SE/color-prop-05-t.svg
will appear as a fail (but is incorrect after the spec changed.)

BUG=571723
==========

[hyunjunekim2, 2015-12-23 11:45:42]

fs, Could you check the description and subject?

[hyunjunekim2, 2015-12-23 11:48:47]

Description was changed from

==========
Latest on the blink, paint the value inherited the color value 
of parent. But According to the specification[1] changed, this 
CL is that paint something property used by `currentColor` as
the `color` property of the same element and it's inherited as
`currentColor` not as the value. 

This updates the application of 'currentColor' to match the
later versions of the spec[1] which states that:

 "If the value is inherited, it’s inherited as currentcolor,
  not as the value of the color property.".

[1] https://drafts.csswg.org/css-color-4/#valdef-color-currentcolor

Because of this, the test svg/W3C-SVG-1.1-SE/color-prop-05-t.svg
will appear as a fail (but is incorrect after the spec changed.)

BUG=571723
==========

to

==========
Latest on the blink, painted the value inherited the color 
value  of parent. But According to the specification[1] 
changed, this CL is that paint something property used by 
`currentColor` as the `color` property of the same element and 
it's inherited as `currentColor` not as the value. 

This updates the application of 'currentColor' to match the
later versions of the spec[1] which states that:

 "If the value is inherited, it’s inherited as currentcolor,
  not as the value of the color property.".

[1] https://drafts.csswg.org/css-color-4/#valdef-color-currentcolor

Because of this, the test svg/W3C-SVG-1.1-SE/color-prop-05-t.svg
will appear as a fail (but is incorrect after the spec changed.)

BUG=571723
==========

[hyunjunekim2, 2015-12-23 11:49:08]

Description was changed from

==========
Latest on the blink, painted the value inherited the color 
value  of parent. But According to the specification[1] 
changed, this CL is that paint something property used by 
`currentColor` as the `color` property of the same element and 
it's inherited as `currentColor` not as the value. 

This updates the application of 'currentColor' to match the
later versions of the spec[1] which states that:

 "If the value is inherited, it’s inherited as currentcolor,
  not as the value of the color property.".

[1] https://drafts.csswg.org/css-color-4/#valdef-color-currentcolor

Because of this, the test svg/W3C-SVG-1.1-SE/color-prop-05-t.svg
will appear as a fail (but is incorrect after the spec changed.)

BUG=571723
==========

to

==========
Latest on the blink, painted the value inherited the color 
value  of parent. But According to the specification[1] 
changed, this CL is that paint something property used by 
`currentColor` as the `color` property of the same element
and it's inherited as `currentColor` not as the value. 

This updates the application of 'currentColor' to match the
later versions of the spec[1] which states that:

 "If the value is inherited, it’s inherited as currentcolor,
  not as the value of the color property.".

[1] https://drafts.csswg.org/css-color-4/#valdef-color-currentcolor

Because of this, the test svg/W3C-SVG-1.1-SE/color-prop-05-t.svg
will appear as a fail (but is incorrect after the spec changed.)

BUG=571723
==========

[fs, 2015-12-23 11:52:02]

On 2015/12/23 at 11:45:42, hyunjune.kim wrote:
> fs, Could you check the description and subject?

I'd suggest something like:

Inherit 'currentColor' as 'currentColor' for 'fill'/'stroke' properties

Or:

Resolve 'currentColor' at used-value time for 'fill'/'stroke' properties

also, the "subject" part of the description should be a single line.

[hyunjunekim2, 2015-12-23 11:59:17]

Description was changed from

==========
Latest on the blink, painted the value inherited the color 
value  of parent. But According to the specification[1] 
changed, this CL is that paint something property used by 
`currentColor` as the `color` property of the same element
and it's inherited as `currentColor` not as the value. 

This updates the application of 'currentColor' to match the
later versions of the spec[1] which states that:

 "If the value is inherited, it’s inherited as currentcolor,
  not as the value of the color property.".

[1] https://drafts.csswg.org/css-color-4/#valdef-color-currentcolor

Because of this, the test svg/W3C-SVG-1.1-SE/color-prop-05-t.svg
will appear as a fail (but is incorrect after the spec changed.)

BUG=571723
==========

to

==========
Inherit 'currentColor' as 'currentColor' for 'fill'/'stroke' 
properties. So this CL is that paint something property used by 
`currentColor` as the `color` property of the same element and
it's inherited as `currentColor` not as the value. 

This updates the application of 'currentColor' to match the
later versions of the spec[1] which states that:

 "If the value is inherited, it’s inherited as currentcolor,
  not as the value of the color property.".

[1] https://drafts.csswg.org/css-color-4/#valdef-color-currentcolor

Because of this, the test svg/W3C-SVG-1.1-SE/color-prop-05-t.svg
will appear as a fail (but is incorrect after the spec changed.)

BUG=571723
==========

[hyunjunekim2, 2015-12-23 12:00:22]

Description was changed from

==========
Inherit 'currentColor' as 'currentColor' for 'fill'/'stroke' 
properties. So this CL is that paint something property used by 
`currentColor` as the `color` property of the same element and
it's inherited as `currentColor` not as the value. 

This updates the application of 'currentColor' to match the
later versions of the spec[1] which states that:

 "If the value is inherited, it’s inherited as currentcolor,
  not as the value of the color property.".

[1] https://drafts.csswg.org/css-color-4/#valdef-color-currentcolor

Because of this, the test svg/W3C-SVG-1.1-SE/color-prop-05-t.svg
will appear as a fail (but is incorrect after the spec changed.)

BUG=571723
==========

to

==========
Inherit 'currentColor' as 'currentColor' for 'fill'/'stroke' 
properties. So this CL is that resolve something property used by `currentColor`
as the `color` property of the same element and it's inherited as `currentColor`
not as the value. 

This updates the application of 'currentColor' to match the
later versions of the spec[1] which states that:

 "If the value is inherited, it’s inherited as currentcolor,
  not as the value of the color property.".

[1] https://drafts.csswg.org/css-color-4/#valdef-color-currentcolor

Because of this, the test svg/W3C-SVG-1.1-SE/color-prop-05-t.svg
will appear as a fail (but is incorrect after the spec changed.)

BUG=571723
==========

[hyunjunekim2, 2015-12-23 12:00:39]

Description was changed from

==========
Inherit 'currentColor' as 'currentColor' for 'fill'/'stroke' 
properties. So this CL is that resolve something property used by `currentColor`
as the `color` property of the same element and it's inherited as `currentColor`
not as the value. 

This updates the application of 'currentColor' to match the
later versions of the spec[1] which states that:

 "If the value is inherited, it’s inherited as currentcolor,
  not as the value of the color property.".

[1] https://drafts.csswg.org/css-color-4/#valdef-color-currentcolor

Because of this, the test svg/W3C-SVG-1.1-SE/color-prop-05-t.svg
will appear as a fail (but is incorrect after the spec changed.)

BUG=571723
==========

to

==========
Inherit 'currentColor' as 'currentColor' for 'fill'/'stroke' 
properties. So this CL is that resolve something property used
by `currentColor` as the `color` property of the same element
and it's inherited as `currentColor` not as the value. 

This updates the application of 'currentColor' to match the
later versions of the spec[1] which states that:

 "If the value is inherited, it’s inherited as currentcolor,
  not as the value of the color property.".

[1] https://drafts.csswg.org/css-color-4/#valdef-color-currentcolor

Because of this, the test svg/W3C-SVG-1.1-SE/color-prop-05-t.svg
will appear as a fail (but is incorrect after the spec changed.)

BUG=571723
==========

[hyunjunekim2, 2015-12-23 12:02:05]

fs, I changed them.

[fs, 2015-12-23 12:16:58]

Description was changed from

==========
Inherit 'currentColor' as 'currentColor' for 'fill'/'stroke' 
properties. So this CL is that resolve something property used
by `currentColor` as the `color` property of the same element
and it's inherited as `currentColor` not as the value. 

This updates the application of 'currentColor' to match the
later versions of the spec[1] which states that:

 "If the value is inherited, it’s inherited as currentcolor,
  not as the value of the color property.".

[1] https://drafts.csswg.org/css-color-4/#valdef-color-currentcolor

Because of this, the test svg/W3C-SVG-1.1-SE/color-prop-05-t.svg
will appear as a fail (but is incorrect after the spec changed.)

BUG=571723
==========

to

==========
Inherit 'currentColor' as 'currentColor' for 'fill'/'stroke' properties

So this CL is that resolve something property used by `currentColor` as
the `color` property of the same element and it's inherited as
`currentColor` not as the value.

This updates the application of 'currentColor' to match the
later versions of the spec[1] which states that:

 "If the value is inherited, it’s inherited as currentcolor,
  not as the value of the color property.".

[1] https://drafts.csswg.org/css-color-4/#valdef-color-currentcolor

Because of this, the test svg/W3C-SVG-1.1-SE/color-prop-05-t.svg
will appear as a fail (but is incorrect after the spec changed.)

BUG=571723
==========

[fs, 2015-12-23 12:17:38]

On 2015/12/23 at 12:02:05, hyunjune.kim wrote:
> fs, I changed them.

I tweaked it a bit for the purpose of illustration. Looks good now.

[hyunjunekim2, 2015-12-23 13:16:51]

On 2015/12/23 12:17:38, fs wrote:
> On 2015/12/23 at 12:02:05, hyunjune.kim wrote:
> > fs, I changed them.
> 
> I tweaked it a bit for the purpose of illustration. Looks good now.

fs, Is it possible that merge this CL?

[hyunjunekim2, 2015-12-23 13:16:54]

The CQ bit was checked by hyunjune.kim@samsung.com

[hyunjunekim2, 2015-12-23 13:16:55]

The CQ bit was unchecked by hyunjune.kim@samsung.com

[hyunjunekim2, 2015-12-23 13:47:02]

The CQ bit was checked by hyunjune.kim@samsung.com

[hyunjunekim2, 2015-12-23 13:47:05]

The CQ bit was unchecked by hyunjune.kim@samsung.com

[hyunjunekim2, 2015-12-23 13:47:06]

The CQ bit was checked by hyunjune.kim@samsung.com

[hyunjunekim2, 2015-12-23 13:47:17]

The CQ bit was unchecked by hyunjune.kim@samsung.com

[commit-bot: I haz the power, 2015-12-23 13:47:25]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1545673002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1545673002/60001

[fs, 2015-12-23 14:10:19]

On 2015/12/23 at 13:16:51, hyunjune.kim wrote:
> On 2015/12/23 12:17:38, fs wrote:
> > On 2015/12/23 at 12:02:05, hyunjune.kim wrote:
> > > fs, I changed them.
> > 
> > I tweaked it a bit for the purpose of illustration. Looks good now.
> 
> fs, Is it possible that merge this CL?

Yes, go ahead and land.

[hyunjunekim2, 2015-12-23 14:11:19]

The CQ bit was checked by hyunjune.kim@samsung.com

[commit-bot: I haz the power, 2015-12-23 14:11:32]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1545673002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1545673002/60001

[commit-bot: I haz the power, 2015-12-23 15:13:40]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2015-12-23 15:14:33]

Description was changed from

==========
Inherit 'currentColor' as 'currentColor' for 'fill'/'stroke' properties

So this CL is that resolve something property used by `currentColor` as
the `color` property of the same element and it's inherited as
`currentColor` not as the value.

This updates the application of 'currentColor' to match the
later versions of the spec[1] which states that:

 "If the value is inherited, it’s inherited as currentcolor,
  not as the value of the color property.".

[1] https://drafts.csswg.org/css-color-4/#valdef-color-currentcolor

Because of this, the test svg/W3C-SVG-1.1-SE/color-prop-05-t.svg
will appear as a fail (but is incorrect after the spec changed.)

BUG=571723
==========

to

==========
Inherit 'currentColor' as 'currentColor' for 'fill'/'stroke' properties

So this CL is that resolve something property used by `currentColor` as
the `color` property of the same element and it's inherited as
`currentColor` not as the value.

This updates the application of 'currentColor' to match the
later versions of the spec[1] which states that:

 "If the value is inherited, it’s inherited as currentcolor,
  not as the value of the color property.".

[1] https://drafts.csswg.org/css-color-4/#valdef-color-currentcolor

Because of this, the test svg/W3C-SVG-1.1-SE/color-prop-05-t.svg
will appear as a fail (but is incorrect after the spec changed.)

BUG=571723

Committed: https://crrev.com/2e92c6870ec900369b54a38e7b015e32e104dce1
Cr-Commit-Position: refs/heads/master@{#366744}
==========

[commit-bot: I haz the power, 2015-12-23 15:14:34]

Patchset 4 (id:??) landed as
https://crrev.com/2e92c6870ec900369b54a38e7b015e32e104dce1
Cr-Commit-Position: refs/heads/master@{#366744}