core/src/fpdfapi/fpdf_render/fpdf_render_loadimage.cpp - Issue 1545563003: Cleanup: Remove unused CFX_PSRenderer and various encoders it used.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: core/src/fpdfapi/fpdf_render/fpdf_render_loadimage.cpp

Issue 1545563003: Cleanup: Remove unused CFX_PSRenderer and various encoders it used. (Closed) Base URL: https://pdfium.googlesource.com/pdfium@master

Patch Set: self review Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « core/src/fpdfapi/fpdf_parser/fpdf_parser_decode_embeddertest.cpp ('k') | core/src/fxcodec/codec/codec_int.h » ('j') | core/src/fxcodec/codec/fx_codec_flate.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: core/src/fpdfapi/fpdf_render/fpdf_render_loadimage.cpp

diff --git a/core/src/fpdfapi/fpdf_render/fpdf_render_loadimage.cpp b/core/src/fpdfapi/fpdf_render/fpdf_render_loadimage.cpp

index 0306ff02270dacc858dc370eec420b7b02d1a620..c107c002c2a498bd6b8f5127bccab6e7c422a166 100644

--- a/core/src/fpdfapi/fpdf_render/fpdf_render_loadimage.cpp

+++ b/core/src/fpdfapi/fpdf_render/fpdf_render_loadimage.cpp

@@ -615,11 +615,11 @@ int CPDF_DIBSource::CreateDecoder() {

src_data, src_size, m_Width, m_Height, m_nComponents,

pParams ? pParams->GetInteger("ColorTransform", 1) : 1);

if (!m_pDecoder) {

- FX_BOOL bTransform = FALSE;

+ bool bTransform = false;

int comps, bpc;

ICodec_JpegModule* pJpegModule = CPDF_ModuleMgr::Get()->GetJpegModule();

- if (pJpegModule->LoadInfo(src_data, src_size, m_Width, m_Height, comps,

- bpc, bTransform)) {

+ if (pJpegModule->LoadInfo(src_data, src_size, &m_Width, &m_Height, &comps,

+ &bpc, &bTransform)) {

if (m_nComponents != comps) {

FX_Free(m_pCompData);

m_nComponents = comps;