Cleanup: Remove unused CFX_PSRenderer and various encoders it used.

Cleanup: Remove unused CFX_PSRenderer and various encoders it used.

- Simplify remaining encoders.
- Hook up more of the encoding paths so failures get returned.
- Clean up code to not pass by non-const ref, use bools, etc.

R=ochang@chromium.org

Committed: https://pdfium.googlesource.com/pdfium/+/2d63eaaa39bb3d402c658b2a6e0eae50a30f1d89

[Lei Zhang, 2015-12-22 03:51:57]

Description was changed from

==========
Cleanup: Remove unused CFX_PSRenderer and various encoders it used.

- Simplify remaining encoders.
- Hook up more of the encoding paths so failures get returned.
- Clean up code to not pass by non-const ref, etc.
==========

to

==========
Cleanup: Remove unused CFX_PSRenderer and various encoders it used.

- Simplify remaining encoders.
- Hook up more of the encoding paths so failures get returned.
- Clean up code to not pass by non-const ref, use bools, etc.
==========

[Lei Zhang, 2015-12-22 03:51:57]

thestig@chromium.org changed reviewers:
+ ochang@chromium.org

[Lei Zhang, 2015-12-22 03:53:30]

weeee!

[Oliver Chang, 2015-12-22 17:35:47]

lgtm

https://codereview.chromium.org/1545563003/diff/20001/core/src/fxcodec/codec/...
File core/src/fxcodec/codec/fx_codec_flate.cpp (right):

https://codereview.chromium.org/1545563003/diff/20001/core/src/fxcodec/codec/...
core/src/fxcodec/codec/fx_codec_flate.cpp:844: *dest_size = (FX_DWORD)temp_size;
Probably doesn't matter, but does it make sense here to set dest_size to
temp_size if FPDFAPI_FlateCompress fails?

https://codereview.chromium.org/1545563003/diff/20001/core/src/fxcodec/codec/...
File core/src/fxcodec/codec/fx_codec_jpeg.cpp (right):

https://codereview.chromium.org/1545563003/diff/20001/core/src/fxcodec/codec/...
core/src/fxcodec/codec/fx_codec_jpeg.cpp:115: return FALSE;
since this returns bool now, change FALSE/TRUE to false/true

https://codereview.chromium.org/1545563003/diff/20001/core/src/fxcodec/codec/...
core/src/fxcodec/codec/fx_codec_jpeg.cpp:120: return FALSE;
ditto

[Lei Zhang, 2015-12-22 22:16:42]

https://codereview.chromium.org/1545563003/diff/20001/core/src/fxcodec/codec/...
File core/src/fxcodec/codec/fx_codec_flate.cpp (right):

https://codereview.chromium.org/1545563003/diff/20001/core/src/fxcodec/codec/...
core/src/fxcodec/codec/fx_codec_flate.cpp:844: *dest_size = (FX_DWORD)temp_size;
On 2015/12/22 17:35:47, Oliver Chang wrote:
> Probably doesn't matter, but does it make sense here to set dest_size to
> temp_size if FPDFAPI_FlateCompress fails?

Well, now that the callers are all checking the value, we should be able to not
set it and it won't matter, because the caller should not be using it.

https://codereview.chromium.org/1545563003/diff/20001/core/src/fxcodec/codec/...
File core/src/fxcodec/codec/fx_codec_jpeg.cpp (right):

https://codereview.chromium.org/1545563003/diff/20001/core/src/fxcodec/codec/...
core/src/fxcodec/codec/fx_codec_jpeg.cpp:115: return FALSE;
On 2015/12/22 17:35:47, Oliver Chang wrote:
> since this returns bool now, change FALSE/TRUE to false/true

Done.

https://codereview.chromium.org/1545563003/diff/20001/core/src/fxcodec/codec/...
core/src/fxcodec/codec/fx_codec_jpeg.cpp:120: return FALSE;
On 2015/12/22 17:35:47, Oliver Chang wrote:
> ditto

Done.

[Lei Zhang, 2015-12-22 22:19:01]

Description was changed from

==========
Cleanup: Remove unused CFX_PSRenderer and various encoders it used.

- Simplify remaining encoders.
- Hook up more of the encoding paths so failures get returned.
- Clean up code to not pass by non-const ref, use bools, etc.
==========

to

==========
Cleanup: Remove unused CFX_PSRenderer and various encoders it used.

- Simplify remaining encoders.
- Hook up more of the encoding paths so failures get returned.
- Clean up code to not pass by non-const ref, use bools, etc.

R=ochang@chromium.org

Committed:
https://pdfium.googlesource.com/pdfium/+/2d63eaaa39bb3d402c658b2a6e0eae50a30f...
==========

[Lei Zhang, 2015-12-22 22:19:03]

Committed patchset #4 (id:60001) manually as
2d63eaaa39bb3d402c658b2a6e0eae50a30f1d89 (presubmit successful).