Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(758)

Side by Side Diff: sync/internal_api/public/base/node_ordinal.h

Issue 1545553003: Switch to standard integer types in sync/. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2012 The Chromium Authors. All rights reserved. 1 // Copyright 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef SYNC_INTERNAL_API_PUBLIC_BASE_NODE_ORDINAL_H_ 5 #ifndef SYNC_INTERNAL_API_PUBLIC_BASE_NODE_ORDINAL_H_
6 #define SYNC_INTERNAL_API_PUBLIC_BASE_NODE_ORDINAL_H_ 6 #define SYNC_INTERNAL_API_PUBLIC_BASE_NODE_ORDINAL_H_
7 7
8 #include <stddef.h>
8 #include <stdint.h> 9 #include <stdint.h>
9 10
10 #include "sync/base/sync_export.h" 11 #include "sync/base/sync_export.h"
11 #include "sync/internal_api/public/base/ordinal.h" 12 #include "sync/internal_api/public/base/ordinal.h"
12 13
13 namespace syncer { 14 namespace syncer {
14 15
15 // A NodeOrdinal is an Ordinal whose internal value comes from the 16 // A NodeOrdinal is an Ordinal whose internal value comes from the
16 // ordinal_in_parent field of SyncEntity (see sync.proto). It uses 17 // ordinal_in_parent field of SyncEntity (see sync.proto). It uses
17 // the entire uint8_t range for backwards compatibility with the old 18 // the entire uint8_t range for backwards compatibility with the old
18 // int64-based positioning. 19 // int64_t-based positioning.
19 20
20 struct NodeOrdinalTraits { 21 struct NodeOrdinalTraits {
21 static const uint8_t kZeroDigit = 0; 22 static const uint8_t kZeroDigit = 0;
22 static const uint8_t kMaxDigit = UINT8_MAX; 23 static const uint8_t kMaxDigit = UINT8_MAX;
23 static const size_t kMinLength = 8; 24 static const size_t kMinLength = 8;
24 }; 25 };
25 26
26 typedef Ordinal<NodeOrdinalTraits> NodeOrdinal; 27 typedef Ordinal<NodeOrdinalTraits> NodeOrdinal;
27 28
28 static_assert(static_cast<char>(NodeOrdinal::kZeroDigit) == '\x00', 29 static_assert(static_cast<char>(NodeOrdinal::kZeroDigit) == '\x00',
29 "NodeOrdinal has incorrect zero digit"); 30 "NodeOrdinal has incorrect zero digit");
30 static_assert(static_cast<char>(NodeOrdinal::kOneDigit) == '\x01', 31 static_assert(static_cast<char>(NodeOrdinal::kOneDigit) == '\x01',
31 "NodeOrdinal has incorrect one digit"); 32 "NodeOrdinal has incorrect one digit");
32 static_assert(static_cast<char>(NodeOrdinal::kMidDigit) == '\x80', 33 static_assert(static_cast<char>(NodeOrdinal::kMidDigit) == '\x80',
33 "NodeOrdinal has incorrect mid digit"); 34 "NodeOrdinal has incorrect mid digit");
34 static_assert(static_cast<char>(NodeOrdinal::kMaxDigit) == '\xff', 35 static_assert(static_cast<char>(NodeOrdinal::kMaxDigit) == '\xff',
35 "NodeOrdinal has incorrect max digit"); 36 "NodeOrdinal has incorrect max digit");
36 static_assert(NodeOrdinal::kMidDigitValue == 128, 37 static_assert(NodeOrdinal::kMidDigitValue == 128,
37 "NodeOrdinal has incorrect mid digit value"); 38 "NodeOrdinal has incorrect mid digit value");
38 static_assert(NodeOrdinal::kMaxDigitValue == 255, 39 static_assert(NodeOrdinal::kMaxDigitValue == 255,
39 "NodeOrdinal has incorrect max digit value"); 40 "NodeOrdinal has incorrect max digit value");
40 static_assert(NodeOrdinal::kRadix == 256, 41 static_assert(NodeOrdinal::kRadix == 256,
41 "NodeOrdinal has incorrect radix"); 42 "NodeOrdinal has incorrect radix");
42 43
43 // Converts an int64 position (usually from the position_in_parent 44 // Converts an int64_t position (usually from the position_in_parent
44 // field of SyncEntity) to a NodeOrdinal. This transformation 45 // field of SyncEntity) to a NodeOrdinal. This transformation
45 // preserves the ordering relation: a < b under integer ordering if 46 // preserves the ordering relation: a < b under integer ordering if
46 // and only if Int64ToNodeOrdinal(a) < Int64ToNodeOrdinal(b). 47 // and only if Int64ToNodeOrdinal(a) < Int64ToNodeOrdinal(b).
47 SYNC_EXPORT NodeOrdinal Int64ToNodeOrdinal(int64_t x); 48 SYNC_EXPORT NodeOrdinal Int64ToNodeOrdinal(int64_t x);
48 49
49 // The inverse of Int64ToNodeOrdinal. This conversion is, in general, 50 // The inverse of Int64ToNodeOrdinal. This conversion is, in general,
50 // lossy: NodeOrdinals can have arbitrary fidelity, while numeric 51 // lossy: NodeOrdinals can have arbitrary fidelity, while numeric
51 // positions contain only 64 bits of information (in fact, this is the 52 // positions contain only 64 bits of information (in fact, this is the
52 // reason we've moved away from them). 53 // reason we've moved away from them).
53 SYNC_EXPORT int64 NodeOrdinalToInt64(const NodeOrdinal& ordinal); 54 SYNC_EXPORT int64_t NodeOrdinalToInt64(const NodeOrdinal& ordinal);
54 55
55 } // namespace syncer 56 } // namespace syncer
56 57
57 #endif // SYNC_INTERNAL_API_PUBLIC_BASE_NODE_ORDINAL_H_ 58 #endif // SYNC_INTERNAL_API_PUBLIC_BASE_NODE_ORDINAL_H_
OLDNEW
« no previous file with comments | « sync/internal_api/public/base/model_type_test_util.cc ('k') | sync/internal_api/public/base/node_ordinal.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698