Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(209)

Issue 154553003: Revert "Enable stack tool and ASan symbolization of logcat on Android bots." (Closed)

Created:
6 years, 10 months ago by navabi
Modified:
6 years, 10 months ago
Reviewers:
CC:
chromium-reviews, craigdh+watch_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, ilevy-cc_chromium.org, klundberg+watch_chromium.org, frankf+watch_chromium.org
Visibility:
Public.

Description

Revert "Enable stack tool and ASan symbolization of logcat on Android bots." This reverts commit dc6d7c9d8d8bd5d29dd7a4fc681bb8c2a0bc3297. Sorry, we can not commit this without the accompanying downstream change, because without that there are two --disable-stack-tool option strings (one in the downstream script and the newly added one here). This causes the following error on the clank tot bot: optparse.OptionConflictError: option --disable-stack-tool: conflicting option string(s): --disable-stack-tool Link: https://chromegw.corp.google.com/i/clank.tot/builders/instrumentation-yakju-clankium-tot/builds/22826/steps/compile/logs/stdio Reverting because this is keeping clank from picking up changes, and I'm not sure how to do a quick fix right now. Removing the option from clank requires the public script to have it, which requires clank to roll. Slightly tricky and I don't have the time to do it today. TBR=craigdh@chromium.org,frankf@chromium.org,navabi@chromium.org,eugenis@chromium.org NOTRY=true BUG=325685 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=248830

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -24 lines) Patch
M build/android/buildbot/bb_device_steps.py View 3 chunks +1 line, -23 lines 0 comments Download
M build/android/buildbot/bb_run_bot.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (0 generated)
navabi
The CQ bit was checked by navabi@google.com
6 years, 10 months ago (2014-02-04 21:59:27 UTC) #1
navabi
The CQ bit was unchecked by navabi@google.com
6 years, 10 months ago (2014-02-04 22:00:19 UTC) #2
navabi
The CQ bit was checked by navabi@google.com
6 years, 10 months ago (2014-02-04 22:08:25 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/navabi@google.com/154553003/1
6 years, 10 months ago (2014-02-04 22:36:47 UTC) #4
navabi
The CQ bit was unchecked by navabi@google.com
6 years, 10 months ago (2014-02-04 23:39:23 UTC) #5
navabi
The CQ bit was checked by navabi@google.com
6 years, 10 months ago (2014-02-04 23:39:28 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/navabi@google.com/154553003/1
6 years, 10 months ago (2014-02-05 01:19:00 UTC) #7
commit-bot: I haz the power
6 years, 10 months ago (2014-02-05 02:05:46 UTC) #8
Message was sent while issue was closed.
Change committed as 248830

Powered by Google App Engine
This is Rietveld 408576698