Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Issue 15455002: Use keyed-call inline caches in delegating yield (Closed)

Created:
7 years, 7 months ago by wingo
Modified:
7 years, 6 months ago
CC:
v8-dev
Visibility:
Public.

Description

Use keyed-call inline caches in delegating yield Since we can't assume anything about the shape of the iterator in a yield* (delegating yield), use an IC to do the next() and throw() iterator method calls. BUG=v8:2691 R=rossberg@chromium.org TEST=mjsunit/regress/regress-2691 Committed: http://code.google.com/p/v8/source/detail?r=15111

Patch Set 1 #

Patch Set 2 : Rebase onto master, adapt to next -> send renaming #

Patch Set 3 : Fix ARM compilation. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -88 lines) Patch
M src/arm/full-codegen-arm.cc View 1 2 2 chunks +7 lines, -23 lines 0 comments Download
M src/ia32/full-codegen-ia32.cc View 1 2 2 chunks +11 lines, -24 lines 0 comments Download
M src/x64/full-codegen-x64.cc View 1 2 2 chunks +12 lines, -27 lines 0 comments Download
A + test/mjsunit/regress/regress-2691.js View 1 1 chunk +5 lines, -14 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
wingo
7 years, 7 months ago (2013-05-20 09:54:34 UTC) #1
wingo
Ping on this one. I don't think there is any ordering issue between this and ...
7 years, 6 months ago (2013-06-07 12:51:43 UTC) #2
wingo
Rebased onto master and adapted for the send -> next renaming. Would be nice to ...
7 years, 6 months ago (2013-06-10 14:58:21 UTC) #3
wingo
Adding Andreas as a possible reviewer :-) This fixes http://code.google.com/p/v8/issues/detail?id=2691.
7 years, 6 months ago (2013-06-12 13:13:07 UTC) #4
rossberg
lgtm
7 years, 6 months ago (2013-06-13 09:34:22 UTC) #5
wingo
7 years, 6 months ago (2013-06-13 10:18:38 UTC) #6
Message was sent while issue was closed.
Committed patchset #3 manually as r15111 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698