Make base a static ibrary

Make base a static ibrary

This saves a nontrivial amount of space for some of the smaller targets in release builds. See the comment added to the base target for more.

Remove libmojo_sdk. This is a complete static library that depended on base. Since base is now a static library, this dependency is not allowed. The mojo team says this target is no longer needed, so it was deleted.

Reland of https://codereview.chromium.org/1528233002/
The difference is that this now depends on https://codereview.chromium.org/1540953003/ which merges base into one library. This prevents the component build issues that were causing problems.

TBR=dpranke@chromium.org

Committed: https://crrev.com/b3c2f366fdcdbe3388b3fda45ae475d4e66dfa88
Cr-Commit-Position: refs/heads/master@{#366621}

[brettw, 2015-12-21 22:12:02]

Description was changed from

==========
Make base a static ibrary

This saves a nontrivial amount of space for some of the smaller targets in
release builds. See the comment added to the base target for more.

Remove libmojo_sdk. This is a complete static library that depended on base.
Since base is now a static library, this dependency is not allowed. The mojo
team says this target is no longer needed, so it was deleted.

Reland of https://codereview.chromium.org/1528233002/
==========

to

==========
Make base a static ibrary

This saves a nontrivial amount of space for some of the smaller targets in
release builds. See the comment added to the base target for more.

Remove libmojo_sdk. This is a complete static library that depended on base.
Since base is now a static library, this dependency is not allowed. The mojo
team says this target is no longer needed, so it was deleted.

Reland of https://codereview.chromium.org/1528233002/
The difference is that this now depends on
https://codereview.chromium.org/1540953003/ which merges base into one library.
This prevents the component build issues that were causing problems.
==========

[brettw, 2015-12-21 22:12:02]

brettw@chromium.org changed reviewers:
+ dpranke@chromium.org

[brettw, 2015-12-21 23:04:33]

The CQ bit was checked by brettw@chromium.org

[commit-bot: I haz the power, 2015-12-21 23:04:48]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1545493002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1545493002/20001

[commit-bot: I haz the power, 2015-12-21 23:04:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-12-21 23:04:50]

No L-G-T-M from a valid reviewer yet. Only full committers are accepted.
Even if an L-G-T-M may have been provided, it was from a non-committer,
_not_ a full super star committer.
See http://www.chromium.org/getting-involved/become-a-committer
Note that this has nothing to do with OWNERS files.

[brettw, 2015-12-21 23:30:53]

The CQ bit was checked by brettw@chromium.org

[commit-bot: I haz the power, 2015-12-21 23:32:39]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1545493002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1545493002/20001

[commit-bot: I haz the power, 2015-12-21 23:32:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-12-21 23:32:45]

No L-G-T-M from a valid reviewer yet. Only full committers are accepted.
Even if an L-G-T-M may have been provided, it was from a non-committer,
_not_ a full super star committer.
See http://www.chromium.org/getting-involved/become-a-committer
Note that this has nothing to do with OWNERS files.

[brettw, 2015-12-22 01:01:52]

The CQ bit was checked by brettw@chromium.org

[brettw, 2015-12-22 01:02:11]

Description was changed from

==========
Make base a static ibrary

This saves a nontrivial amount of space for some of the smaller targets in
release builds. See the comment added to the base target for more.

Remove libmojo_sdk. This is a complete static library that depended on base.
Since base is now a static library, this dependency is not allowed. The mojo
team says this target is no longer needed, so it was deleted.

Reland of https://codereview.chromium.org/1528233002/
The difference is that this now depends on
https://codereview.chromium.org/1540953003/ which merges base into one library.
This prevents the component build issues that were causing problems.
==========

to

==========
Make base a static ibrary

This saves a nontrivial amount of space for some of the smaller targets in
release builds. See the comment added to the base target for more.

Remove libmojo_sdk. This is a complete static library that depended on base.
Since base is now a static library, this dependency is not allowed. The mojo
team says this target is no longer needed, so it was deleted.

Reland of https://codereview.chromium.org/1528233002/
The difference is that this now depends on
https://codereview.chromium.org/1540953003/ which merges base into one library.
This prevents the component build issues that were causing problems.

TBR=dpranke@chromium.org
==========

[brettw, 2015-12-22 01:02:18]

The CQ bit was unchecked by brettw@chromium.org

[brettw, 2015-12-22 01:02:23]

The CQ bit was checked by brettw@chromium.org

[commit-bot: I haz the power, 2015-12-22 01:03:07]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1545493002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1545493002/20001

[commit-bot: I haz the power, 2015-12-22 01:33:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-12-22 01:34:01]

Try jobs failed on following builders:
  linux_chromium_compile_dbg_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[brettw, 2015-12-22 17:59:41]

The CQ bit was checked by brettw@chromium.org

[commit-bot: I haz the power, 2015-12-22 17:59:59]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1545493002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1545493002/40001

[commit-bot: I haz the power, 2015-12-22 18:33:53]

Description was changed from

==========
Make base a static ibrary

This saves a nontrivial amount of space for some of the smaller targets in
release builds. See the comment added to the base target for more.

Remove libmojo_sdk. This is a complete static library that depended on base.
Since base is now a static library, this dependency is not allowed. The mojo
team says this target is no longer needed, so it was deleted.

Reland of https://codereview.chromium.org/1528233002/
The difference is that this now depends on
https://codereview.chromium.org/1540953003/ which merges base into one library.
This prevents the component build issues that were causing problems.

TBR=dpranke@chromium.org
==========

to

==========
Make base a static ibrary

This saves a nontrivial amount of space for some of the smaller targets in
release builds. See the comment added to the base target for more.

Remove libmojo_sdk. This is a complete static library that depended on base.
Since base is now a static library, this dependency is not allowed. The mojo
team says this target is no longer needed, so it was deleted.

Reland of https://codereview.chromium.org/1528233002/
The difference is that this now depends on
https://codereview.chromium.org/1540953003/ which merges base into one library.
This prevents the component build issues that were causing problems.

TBR=dpranke@chromium.org
==========

[commit-bot: I haz the power, 2015-12-22 18:33:54]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-12-22 18:34:58]

Description was changed from

==========
Make base a static ibrary

This saves a nontrivial amount of space for some of the smaller targets in
release builds. See the comment added to the base target for more.

Remove libmojo_sdk. This is a complete static library that depended on base.
Since base is now a static library, this dependency is not allowed. The mojo
team says this target is no longer needed, so it was deleted.

Reland of https://codereview.chromium.org/1528233002/
The difference is that this now depends on
https://codereview.chromium.org/1540953003/ which merges base into one library.
This prevents the component build issues that were causing problems.

TBR=dpranke@chromium.org
==========

to

==========
Make base a static ibrary

This saves a nontrivial amount of space for some of the smaller targets in
release builds. See the comment added to the base target for more.

Remove libmojo_sdk. This is a complete static library that depended on base.
Since base is now a static library, this dependency is not allowed. The mojo
team says this target is no longer needed, so it was deleted.

Reland of https://codereview.chromium.org/1528233002/
The difference is that this now depends on
https://codereview.chromium.org/1540953003/ which merges base into one library.
This prevents the component build issues that were causing problems.

TBR=dpranke@chromium.org

Committed: https://crrev.com/b3c2f366fdcdbe3388b3fda45ae475d4e66dfa88
Cr-Commit-Position: refs/heads/master@{#366621}
==========

[commit-bot: I haz the power, 2015-12-22 18:34:59]

Patchset 3 (id:??) landed as
https://crrev.com/b3c2f366fdcdbe3388b3fda45ae475d4e66dfa88
Cr-Commit-Position: refs/heads/master@{#366621}

[Dirk Pranke, 2015-12-23 03:41:58]

thought I reviewed this already. lgtm.

https://codereview.chromium.org/1545493002/diff/40001/base/BUILD.gn
File base/BUILD.gn (right):

https://codereview.chromium.org/1545493002/diff/40001/base/BUILD.gn#newcode116
base/BUILD.gn:116: # hacl_helper_nonsfi doesn't link properly on Linux in debug
builds. The
nit: s/hacl_helper_nonsfi/nacl_helper_nonsfi