Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(991)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1545483003: Dart: Reorganize files (Closed)

Created:
5 years ago by zra
Modified:
5 years ago
Reviewers:
Cutch
CC:
mojo-reviews_chromium.org, gregsimon, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Dart: Reorganize files This change attempts to provide a more rational structure for Dart-related code. As much as possible code is moved under //mojo/dart. The layout is now: apptests/ dart_apptests/ (moved from //services/dart/dart_apptests) test_apps/ (moved from //services/dart/tests) embedder/ snapshotter/ (moved from //mojo/dart/dart_snapshotter) packages/ (no changes) tools/ (no changes) unittests/ embedder_tester/ (moved from //mojo/dart/embedder/test) embedder_tests/ (moved from //mojo/dart/test) http_load_test/ (moved from //mojo/dart/http_load_test) observatory_test/ (moved from //mojo/dart/observatory_test) observatory_tester/ (moved from //mojo/dart/observatory_tester) I've also consolidated .gitignore rules under //.gitignore and deleted stray pubspec.lock files. R=johnmccutchan@google.com Committed: https://chromium.googlesource.com/external/mojo/+/1fc045b37741bdc9deaa9320ea4643f46be77a3f

Patch Set 1 #

Patch Set 2 : Fix dart snapshotter test #

Patch Set 3 : Delete pubspec.lock files #

Patch Set 4 : Fix build file #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -5740 lines) Patch
M .gitignore View 1 chunk +13 lines, -31 lines 0 comments Download
D benchmarks/mojo_rtt_benchmark/pubspec.lock View 1 2 1 chunk +0 lines, -35 lines 0 comments Download
M build/module_args/dart.gni View 1 chunk +2 lines, -1 line 0 comments Download
D examples/dart/camera_roll/pubspec.lock View 1 2 1 chunk +0 lines, -219 lines 0 comments Download
D examples/dart/camera_video/pubspec.lock View 1 2 1 chunk +0 lines, -219 lines 0 comments Download
D examples/dart/device_info/pubspec.lock View 1 2 1 chunk +0 lines, -3 lines 0 comments Download
D examples/dart/echo_client/pubspec.lock View 1 2 1 chunk +0 lines, -29 lines 0 comments Download
D examples/dart/hello_world/hello/pubspec.lock View 1 2 1 chunk +0 lines, -3 lines 0 comments Download
D examples/dart/hello_world/world/pubspec.lock View 1 2 1 chunk +0 lines, -3 lines 0 comments Download
D examples/dart/netcat/pubspec.lock View 1 2 1 chunk +0 lines, -3 lines 0 comments Download
D examples/dart/wget/pubspec.lock View 1 2 1 chunk +0 lines, -31 lines 0 comments Download
M mojo/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M mojo/dart/BUILD.gn View 1 2 3 1 chunk +10 lines, -5 lines 0 comments Download
A + mojo/dart/apptests/BUILD.gn View 1 chunk +3 lines, -4 lines 0 comments Download
A + mojo/dart/apptests/dart_apptests/BUILD.gn View 1 chunk +1 line, -6 lines 0 comments Download
A + mojo/dart/apptests/dart_apptests/lib/main.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + mojo/dart/apptests/dart_apptests/lib/src/connect_to_loader_apptests.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + mojo/dart/apptests/dart_apptests/lib/src/echo_apptests.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + mojo/dart/apptests/dart_apptests/lib/src/file_apptests.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + mojo/dart/apptests/dart_apptests/lib/src/io_http_apptests.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + mojo/dart/apptests/dart_apptests/lib/src/io_internet_address_apptests.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + mojo/dart/apptests/dart_apptests/lib/src/pingpong_apptests.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + mojo/dart/apptests/dart_apptests/lib/src/versioning_apptests.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + mojo/dart/apptests/dart_apptests/pubspec.yaml View 0 chunks +-1 lines, --1 lines 0 comments Download
A + mojo/dart/apptests/test_apps/BUILD.gn View 1 chunk +10 lines, -0 lines 0 comments Download
A + mojo/dart/apptests/test_apps/echo/BUILD.gn View 1 chunk +2 lines, -2 lines 0 comments Download
A + mojo/dart/apptests/test_apps/echo/lib/main.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + mojo/dart/apptests/test_apps/echo/pubspec.yaml View 0 chunks +-1 lines, --1 lines 0 comments Download
A + mojo/dart/apptests/test_apps/interfaces/echo_service.mojom View 0 chunks +-1 lines, --1 lines 0 comments Download
A + mojo/dart/apptests/test_apps/interfaces/pingpong_service.mojom View 0 chunks +-1 lines, --1 lines 0 comments Download
A + mojo/dart/apptests/test_apps/pingpong/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
A + mojo/dart/apptests/test_apps/pingpong/lib/main.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + mojo/dart/apptests/test_apps/pingpong/pubspec.yaml View 0 chunks +-1 lines, --1 lines 0 comments Download
A + mojo/dart/apptests/test_apps/pingpong_target/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
A + mojo/dart/apptests/test_apps/pingpong_target/lib/main.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + mojo/dart/apptests/test_apps/pingpong_target/pubspec.yaml View 0 chunks +-1 lines, --1 lines 0 comments Download
D mojo/dart/dart_snapshotter/BUILD.gn View 1 chunk +0 lines, -28 lines 0 comments Download
D mojo/dart/dart_snapshotter/main.cc View 1 chunk +0 lines, -101 lines 0 comments Download
D mojo/dart/dart_snapshotter/test/dart_snapshotter_test.py View 1 chunk +0 lines, -83 lines 0 comments Download
D mojo/dart/dart_snapshotter/vm.h View 1 chunk +0 lines, -45 lines 0 comments Download
D mojo/dart/dart_snapshotter/vm.cc View 1 chunk +0 lines, -44 lines 0 comments Download
M mojo/dart/embedder/BUILD.gn View 1 chunk +8 lines, -0 lines 0 comments Download
A + mojo/dart/embedder/snapshotter/BUILD.gn View 1 chunk +6 lines, -0 lines 0 comments Download
A + mojo/dart/embedder/snapshotter/main.cc View 1 chunk +1 line, -1 line 0 comments Download
A + mojo/dart/embedder/snapshotter/test/dart_snapshotter_test.py View 1 1 chunk +1 line, -1 line 0 comments Download
A + mojo/dart/embedder/snapshotter/vm.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + mojo/dart/embedder/snapshotter/vm.cc View 1 chunk +1 line, -1 line 0 comments Download
D mojo/dart/embedder/test/BUILD.gn View 1 chunk +0 lines, -102 lines 0 comments Download
D mojo/dart/embedder/test/dart_finalizer_test.cc View 1 chunk +0 lines, -53 lines 0 comments Download
D mojo/dart/embedder/test/dart_test.h View 1 chunk +0 lines, -57 lines 0 comments Download
D mojo/dart/embedder/test/dart_test.cc View 1 chunk +0 lines, -65 lines 0 comments Download
D mojo/dart/embedder/test/dart_to_cpp.mojom View 1 chunk +0 lines, -54 lines 0 comments Download
D mojo/dart/embedder/test/dart_to_cpp_tests.cc View 1 chunk +0 lines, -360 lines 0 comments Download
D mojo/dart/embedder/test/dart_to_cpp_tests.dart View 1 chunk +0 lines, -119 lines 0 comments Download
D mojo/dart/embedder/test/run_dart_tests.cc View 1 chunk +0 lines, -117 lines 0 comments Download
D mojo/dart/embedder/test/validation_unittest.cc View 1 chunk +0 lines, -112 lines 0 comments Download
D mojo/dart/http_load_test/BUILD.gn View 1 chunk +0 lines, -20 lines 0 comments Download
D mojo/dart/http_load_test/bin/tester.dart View 1 chunk +0 lines, -74 lines 0 comments Download
D mojo/dart/http_load_test/lib/main.dart View 1 chunk +0 lines, -18 lines 0 comments Download
D mojo/dart/http_load_test/lib/src/part0.dart View 1 chunk +0 lines, -3 lines 0 comments Download
D mojo/dart/http_load_test/pubspec.lock View 1 chunk +0 lines, -3 lines 0 comments Download
D mojo/dart/http_load_test/pubspec.yaml View 1 chunk +0 lines, -1 line 0 comments Download
D mojo/dart/http_load_test/runner.py View 1 chunk +0 lines, -47 lines 0 comments Download
D mojo/dart/observatory_test/.gitignore View 1 chunk +0 lines, -2 lines 0 comments Download
D mojo/dart/observatory_test/BUILD.gn View 1 chunk +0 lines, -18 lines 0 comments Download
D mojo/dart/observatory_test/lib/main.dart View 1 chunk +0 lines, -7 lines 0 comments Download
D mojo/dart/observatory_test/pubspec.yaml View 1 chunk +0 lines, -3 lines 0 comments Download
D mojo/dart/observatory_tester/runner.py View 1 chunk +0 lines, -44 lines 0 comments Download
D mojo/dart/observatory_tester/tester.dart View 1 chunk +0 lines, -187 lines 0 comments Download
D mojo/dart/packages/.gitignore View 1 chunk +0 lines, -3 lines 0 comments Download
D mojo/dart/packages/mojom/.gitignore View 1 chunk +0 lines, -1 line 0 comments Download
D mojo/dart/test/async_await_test.dart View 1 chunk +0 lines, -12 lines 0 comments Download
D mojo/dart/test/async_test.dart View 1 chunk +0 lines, -11 lines 0 comments Download
D mojo/dart/test/bindings_generation_test.dart View 1 chunk +0 lines, -403 lines 0 comments Download
D mojo/dart/test/codec_test.dart View 1 chunk +0 lines, -746 lines 0 comments Download
D mojo/dart/test/compile_all_interfaces_test.dart View 1 chunk +0 lines, -34 lines 0 comments Download
D mojo/dart/test/control_messages_test.dart View 1 chunk +0 lines, -106 lines 0 comments Download
D mojo/dart/test/core_test.dart View 1 chunk +0 lines, -339 lines 0 comments Download
D mojo/dart/test/core_types_test.dart View 1 chunk +0 lines, -19 lines 0 comments Download
D mojo/dart/test/exception_test.dart View 1 chunk +0 lines, -14 lines 0 comments Download
D mojo/dart/test/handle_finalizer_test.dart View 1 chunk +0 lines, -45 lines 0 comments Download
D mojo/dart/test/hello_mojo.dart View 1 chunk +0 lines, -7 lines 0 comments Download
D mojo/dart/test/import_mojo.dart View 1 chunk +0 lines, -12 lines 0 comments Download
D mojo/dart/test/isolate_test.dart View 1 chunk +0 lines, -31 lines 0 comments Download
D mojo/dart/test/ping_pong_test.dart View 1 chunk +0 lines, -79 lines 0 comments Download
D mojo/dart/test/shared_buffer_finalizer_test.dart View 1 chunk +0 lines, -35 lines 0 comments Download
D mojo/dart/test/simple_handle_watcher_test.dart View 1 chunk +0 lines, -32 lines 0 comments Download
D mojo/dart/test/timer_test.dart View 1 chunk +0 lines, -11 lines 0 comments Download
D mojo/dart/test/unhandled_exception_test.dart View 1 chunk +0 lines, -10 lines 0 comments Download
D mojo/dart/test/uri_base_test.dart View 1 chunk +0 lines, -9 lines 0 comments Download
D mojo/dart/test/validation_test.dart View 1 chunk +0 lines, -136 lines 0 comments Download
M mojo/dart/tools/presubmit/check_mojom_dart.py View 1 chunk +1 line, -0 lines 0 comments Download
A + mojo/dart/unittests/BUILD.gn View 1 chunk +6 lines, -7 lines 0 comments Download
A + mojo/dart/unittests/embedder_tester/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
A + mojo/dart/unittests/embedder_tester/dart_finalizer_test.cc View 2 chunks +3 lines, -2 lines 0 comments Download
A + mojo/dart/unittests/embedder_tester/dart_test.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + mojo/dart/unittests/embedder_tester/dart_test.cc View 1 chunk +1 line, -1 line 0 comments Download
A + mojo/dart/unittests/embedder_tester/dart_to_cpp.mojom View 0 chunks +-1 lines, --1 lines 0 comments Download
A + mojo/dart/unittests/embedder_tester/dart_to_cpp_tests.cc View 2 chunks +4 lines, -4 lines 0 comments Download
A + mojo/dart/unittests/embedder_tester/run_dart_tests.cc View 2 chunks +3 lines, -2 lines 0 comments Download
A + mojo/dart/unittests/embedder_tester/validation_unittest.cc View 2 chunks +3 lines, -2 lines 0 comments Download
A + mojo/dart/unittests/embedder_tests/async_await_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + mojo/dart/unittests/embedder_tests/async_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + mojo/dart/unittests/embedder_tests/bindings_generation_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + mojo/dart/unittests/embedder_tests/codec_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + mojo/dart/unittests/embedder_tests/compile_all_interfaces_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + mojo/dart/unittests/embedder_tests/control_messages_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + mojo/dart/unittests/embedder_tests/core_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + mojo/dart/unittests/embedder_tests/core_types_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + mojo/dart/unittests/embedder_tests/dart_to_cpp_tests.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + mojo/dart/unittests/embedder_tests/exception_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + mojo/dart/unittests/embedder_tests/handle_finalizer_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + mojo/dart/unittests/embedder_tests/hello_mojo.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + mojo/dart/unittests/embedder_tests/import_mojo.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + mojo/dart/unittests/embedder_tests/isolate_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + mojo/dart/unittests/embedder_tests/ping_pong_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + mojo/dart/unittests/embedder_tests/shared_buffer_finalizer_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + mojo/dart/unittests/embedder_tests/simple_handle_watcher_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + mojo/dart/unittests/embedder_tests/timer_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + mojo/dart/unittests/embedder_tests/unhandled_exception_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + mojo/dart/unittests/embedder_tests/uri_base_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + mojo/dart/unittests/embedder_tests/validation_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + mojo/dart/unittests/http_load_test/BUILD.gn View 0 chunks +-1 lines, --1 lines 0 comments Download
A + mojo/dart/unittests/http_load_test/bin/tester.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + mojo/dart/unittests/http_load_test/lib/main.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + mojo/dart/unittests/http_load_test/lib/src/part0.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + mojo/dart/unittests/http_load_test/pubspec.yaml View 0 chunks +-1 lines, --1 lines 0 comments Download
A + mojo/dart/unittests/http_load_test/runner.py View 0 chunks +-1 lines, --1 lines 0 comments Download
A + mojo/dart/unittests/observatory_test/BUILD.gn View 0 chunks +-1 lines, --1 lines 0 comments Download
A + mojo/dart/unittests/observatory_test/lib/main.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + mojo/dart/unittests/observatory_test/pubspec.yaml View 0 chunks +-1 lines, --1 lines 0 comments Download
A + mojo/dart/unittests/observatory_tester/runner.py View 0 chunks +-1 lines, --1 lines 0 comments Download
A + mojo/dart/unittests/observatory_tester/tester.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
M mojo/tools/get_test_list.py View 2 chunks +5 lines, -3 lines 0 comments Download
M services/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
D services/dart/dart_apptests/.gitignore View 1 chunk +0 lines, -3 lines 0 comments Download
D services/dart/dart_apptests/BUILD.gn View 1 chunk +0 lines, -32 lines 0 comments Download
D services/dart/dart_apptests/lib/main.dart View 1 chunk +0 lines, -27 lines 0 comments Download
D services/dart/dart_apptests/lib/src/connect_to_loader_apptests.dart View 1 chunk +0 lines, -26 lines 0 comments Download
D services/dart/dart_apptests/lib/src/echo_apptests.dart View 1 chunk +0 lines, -224 lines 0 comments Download
D services/dart/dart_apptests/lib/src/file_apptests.dart View 1 chunk +0 lines, -189 lines 0 comments Download
D services/dart/dart_apptests/lib/src/io_http_apptests.dart View 1 chunk +0 lines, -72 lines 0 comments Download
D services/dart/dart_apptests/lib/src/io_internet_address_apptests.dart View 1 chunk +0 lines, -67 lines 0 comments Download
D services/dart/dart_apptests/lib/src/pingpong_apptests.dart View 1 chunk +0 lines, -119 lines 0 comments Download
D services/dart/dart_apptests/lib/src/versioning_apptests.dart View 1 chunk +0 lines, -139 lines 0 comments Download
D services/dart/dart_apptests/pubspec.yaml View 1 chunk +0 lines, -1 line 0 comments Download
D services/dart/test/BUILD.gn View 1 chunk +0 lines, -17 lines 0 comments Download
D services/dart/test/dart/service_test_interfaces/BUILD.gn View 1 chunk +0 lines, -16 lines 0 comments Download
D services/dart/test/dart/service_test_interfaces/pubspec.yaml View 1 chunk +0 lines, -1 line 0 comments Download
D services/dart/test/echo/BUILD.gn View 1 chunk +0 lines, -20 lines 0 comments Download
D services/dart/test/echo/lib/main.dart View 1 chunk +0 lines, -55 lines 0 comments Download
D services/dart/test/echo/pubspec.lock View 1 chunk +0 lines, -3 lines 0 comments Download
D services/dart/test/echo/pubspec.yaml View 1 chunk +0 lines, -1 line 0 comments Download
D services/dart/test/interfaces/echo_service.mojom View 1 chunk +0 lines, -12 lines 0 comments Download
D services/dart/test/interfaces/pingpong_service.mojom View 1 chunk +0 lines, -33 lines 0 comments Download
D services/dart/test/pingpong/BUILD.gn View 1 chunk +0 lines, -20 lines 0 comments Download
D services/dart/test/pingpong/lib/main.dart View 1 chunk +0 lines, -126 lines 0 comments Download
D services/dart/test/pingpong/pubspec.lock View 1 chunk +0 lines, -3 lines 0 comments Download
D services/dart/test/pingpong/pubspec.yaml View 1 chunk +0 lines, -1 line 0 comments Download
D services/dart/test/pingpong_target/BUILD.gn View 1 chunk +0 lines, -20 lines 0 comments Download
D services/dart/test/pingpong_target/lib/main.dart View 1 chunk +0 lines, -68 lines 0 comments Download
D services/dart/test/pingpong_target/pubspec.lock View 1 chunk +0 lines, -3 lines 0 comments Download
D services/dart/test/pingpong_target/pubspec.yaml View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 6 (3 generated)
zra
5 years ago (2015-12-22 21:16:22 UTC) #3
Cutch
lgtm
5 years ago (2015-12-22 21:20:36 UTC) #4
zra
5 years ago (2015-12-22 21:36:26 UTC) #6
Message was sent while issue was closed. 
Committed patchset #4 (id:60001) manually as
1fc045b37741bdc9deaa9320ea4643f46be77a3f (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698