Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(99)

Issue 1545473002: Revert Active Verifier tests (Closed)

Created:
5 years ago by Will Harris
Modified:
5 years ago
Reviewers:
cpu_(ooo_6.6-7.5)
CC:
chromium-reviews, grt+watch_chromium.org, wfh+watch_chromium.org, vmpstr+watch_chromium.org, Finnur
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

These caused failures on debug win7 bots that need further investigation. Reverting all the CLs, taking a step back, try again next year. This reverts commit 7969a476e9d9c755811ee49a2de51421360790e8. This reverts commit fdd35a81b4c360208bc0d6d7a2f61f5e8ad652db. BUG=571304, 570912, 481095 TBR=cpu@chromium.org Committed: https://crrev.com/360c186bfcca1dac73ff32d90c99ec476dbe28e0 Cr-Commit-Position: refs/heads/master@{#366445}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+90 lines, -436 lines) Patch
M base/base.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
M base/debug/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
D base/debug/close_handle_hook_win.h View 1 chunk +0 lines, -23 lines 0 comments Download
D base/debug/close_handle_hook_win.cc View 1 chunk +0 lines, -282 lines 0 comments Download
M base/test/run_all_unittests.cc View 1 chunk +1 line, -12 lines 0 comments Download
M base/win/scoped_handle.cc View 4 chunks +5 lines, -5 lines 0 comments Download
M base/win/scoped_handle_unittest.cc View 2 chunks +0 lines, -38 lines 0 comments Download
M chrome/BUILD.gn View 2 chunks +4 lines, -0 lines 0 comments Download
M chrome/app/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/app/chrome_main_delegate.cc View 3 chunks +4 lines, -21 lines 0 comments Download
A chrome/app/close_handle_hook_win.h View 1 chunk +14 lines, -0 lines 0 comments Download
A + chrome/app/close_handle_hook_win.cc View 6 chunks +54 lines, -51 lines 0 comments Download
M chrome/chrome_dll.gypi View 2 chunks +4 lines, -0 lines 0 comments Download
M chrome/chrome_tests_unit.gypi View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (6 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1545473002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1545473002/1
5 years ago (2015-12-21 18:21:57 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-21 19:48:14 UTC) #7
commit-bot: I haz the power
5 years ago (2015-12-21 19:49:09 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/360c186bfcca1dac73ff32d90c99ec476dbe28e0
Cr-Commit-Position: refs/heads/master@{#366445}

Powered by Google App Engine
This is Rietveld 408576698