Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Issue 1545453002: Change bug number of paint/selection/seleciton-within-composited-scroller.html (Closed)

Created:
5 years ago by Xianzhu
Modified:
5 years ago
Reviewers:
Noel Gordon
CC:
chromium-reviews, blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Change bug number of paint/selection/seleciton-within-composited-scroller.html It's not bug 536999 causing the test needing manual rebaseline. Bug 570401 is. BUG=570401 TBR=noel@chromium.org Committed: https://crrev.com/de21252d473ce0180462fc4d3e83e38288653d11 Cr-Commit-Position: refs/heads/master@{#366407}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M third_party/WebKit/LayoutTests/TestExpectations View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (1 generated)
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/de21252d473ce0180462fc4d3e83e38288653d11 Cr-Commit-Position: refs/heads/master@{#366407}
5 years ago (2015-12-21 17:40:10 UTC) #2
Noel Gordon
LGTM - the test lost its scroll bars, iirc, so that might have been some ...
5 years ago (2015-12-21 22:40:13 UTC) #3
Xianzhu
On 2015/12/21 22:40:13, noel gordon wrote: > LGTM - the test lost its scroll bars, ...
5 years ago (2015-12-21 22:57:15 UTC) #4
Noel Gordon
On 2015/12/21 22:57:15, Xianzhu wrote: > On 2015/12/21 22:40:13, noel gordon wrote: > > LGTM ...
5 years ago (2015-12-21 23:34:38 UTC) #5
Xianzhu
On 2015/12/21 23:34:38, noel gordon wrote: > On 2015/12/21 22:57:15, Xianzhu wrote: > > On ...
5 years ago (2015-12-21 23:42:50 UTC) #6
Noel Gordon
On 2015/12/21 23:42:50, Xianzhu wrote: > On 2015/12/21 23:34:38, noel gordon wrote: > > On ...
5 years ago (2015-12-22 00:07:27 UTC) #7
Noel Gordon
On 2015/12/21 23:42:50, Xianzhu wrote: > > According to the flakyness dashboard, the test bounced ...
5 years ago (2015-12-22 00:09:01 UTC) #8
Xianzhu
5 years ago (2015-12-22 00:10:49 UTC) #9
Message was sent while issue was closed.
On 2015/12/22 00:07:27, noel gordon wrote:
> On 2015/12/21 23:42:50, Xianzhu wrote:
> > On 2015/12/21 23:34:38, noel gordon wrote:
> > > On 2015/12/21 22:57:15, Xianzhu wrote:
> > > > On 2015/12/21 22:40:13, noel gordon wrote:
> > > > > LGTM - the test lost its scroll bars, iirc, so that might have been
some
> > > other
> > > > > issue.  That's why I retained the original bug number...
> > > > 
> > > > Can you provide more information about "the test lost its scroll bars",
> e.g.
> > > > link to the bot result?
> > > 
> > >
> >
>
https://storage.googleapis.com/chromium-layout-test-archives/WebKit_Mac10_6/4...
> > > 
> > > is the example I recall.
> > 
> > The actual result is correct. I still didn't see "the test lost its scroll
> > bars".
> 
> Gardeners looks at diffs when lots of tree brokenness is active and too little
> time to debug individual tests that should not have changed behavior in the
> first place.
> 
>
https://storage.googleapis.com/chromium-layout-test-archives/WebKit_Mac10_6/4...
> 
> "Something" changed with scroll bars.

This seems a different test that this CL involves.

Powered by Google App Engine
This is Rietveld 408576698