Helper for checking if an SVGTextFragment is transformed

Helper for checking if an SVGTextFragment is transformed

Add a isTransformed() helper to SVGTextFragment. Since it's a commonly
recurring pattern to compute the fragment transform and then check if
it is the identity transform - and doing the check before actually
computing the transform is only marginally more expensive (since we
know the structure of SVGTextFragment::lengthAdjustTransform) we can
use this helper and switch order of computation and check. The only
potential downside would be if the resulting transform ends up being
the identity transform - which seems like an edge-case.

With this in place, we can do additional improvements around the
handling of fragment bounding boxes et.c. and change how the fragment
is "parametrized".

BUG=571415
Committed: https://crrev.com/6d462873c9d90978d22c52de38fb16c44a181ce1
Cr-Commit-Position: refs/heads/master@{#366567}

[fs, 2015-12-21 18:39:22]

fs@opera.com changed reviewers:
+ pdr@chromium.org

[pdr., 2015-12-22 03:31:40]

LGTM

[fs, 2015-12-22 08:35:52]

The CQ bit was checked by fs@opera.com

[commit-bot: I haz the power, 2015-12-22 08:36:04]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1545443002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1545443002/1

[commit-bot: I haz the power, 2015-12-22 08:40:46]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2015-12-22 08:41:52]

Description was changed from

==========
Helper for checking if an SVGTextFragment is transformed

Add a isTransformed() helper to SVGTextFragment. Since it's a commonly
recurring pattern to compute the fragment transform and then check if
it is the identity transform - and doing the check before actually
computing the transform is only marginally more expensive (since we
know the structure of SVGTextFragment::lengthAdjustTransform) we can
use this helper and switch order of computation and check. The only
potential downside would be if the resulting transform ends up being
the identity transform - which seems like an edge-case.

With this in place, we can do additional improvements around the
handling of fragment bounding boxes et.c. and change how the fragment
is "parametrized".

BUG=571415
==========

to

==========
Helper for checking if an SVGTextFragment is transformed

Add a isTransformed() helper to SVGTextFragment. Since it's a commonly
recurring pattern to compute the fragment transform and then check if
it is the identity transform - and doing the check before actually
computing the transform is only marginally more expensive (since we
know the structure of SVGTextFragment::lengthAdjustTransform) we can
use this helper and switch order of computation and check. The only
potential downside would be if the resulting transform ends up being
the identity transform - which seems like an edge-case.

With this in place, we can do additional improvements around the
handling of fragment bounding boxes et.c. and change how the fragment
is "parametrized".

BUG=571415

Committed: https://crrev.com/6d462873c9d90978d22c52de38fb16c44a181ce1
Cr-Commit-Position: refs/heads/master@{#366567}
==========

[commit-bot: I haz the power, 2015-12-22 08:41:53]

Patchset 1 (id:??) landed as
https://crrev.com/6d462873c9d90978d22c52de38fb16c44a181ce1
Cr-Commit-Position: refs/heads/master@{#366567}