Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(176)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1545343002: Add a missing switch-case break in PPAPI SerializedHandle (Closed)

Created:
4 years, 12 months ago by tzik
Modified:
4 years, 12 months ago
Reviewers:
bbudge
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add a missing switch-case break in PPAPI SerializedHandle BUG= Committed: https://crrev.com/c8737861ba65c1ad300e822365f19629b35d1518 Cr-Commit-Position: refs/heads/master@{#367015}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M ppapi/proxy/serialized_handle.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
tzik
PTAL
4 years, 12 months ago (2015-12-28 01:06:35 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1545343002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1545343002/1
4 years, 12 months ago (2015-12-28 01:06:46 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 12 months ago (2015-12-28 02:02:58 UTC) #6
bbudge
lgtm
4 years, 12 months ago (2015-12-28 16:50:53 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1545343002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1545343002/1
4 years, 12 months ago (2015-12-28 22:06:36 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 12 months ago (2015-12-28 22:11:33 UTC) #10
commit-bot: I haz the power
4 years, 12 months ago (2015-12-28 22:12:30 UTC) #12
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/c8737861ba65c1ad300e822365f19629b35d1518
Cr-Commit-Position: refs/heads/master@{#367015}

Powered by Google App Engine
This is Rietveld 408576698