Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(103)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1545333002: Convert Pass()→std::move() in //third_party/mojo (Closed)

Created:
4 years, 12 months ago by dcheng
Modified:
4 years, 12 months ago
CC:
Aaron Boodman, abarth-chromium, ben+mojo_chromium.org, chromium-reviews, darin (slow to review), qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Convert Pass()→std::move() in //third_party/mojo ❆(੭ु ◜◡‾)੭ु⁾☃❆ BUG=557422 R=avi@chromium.org TBR=yzshen@chromium.org Committed: https://crrev.com/3fdc85f2dbc3e7eed608bebf3e9eaf9b87454807 Cr-Commit-Position: refs/heads/master@{#366942}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+227 lines, -190 lines) Patch
M third_party/mojo/src/mojo/edk/embedder/embedder.cc View 11 chunks +16 lines, -17 lines 0 comments Download
M third_party/mojo/src/mojo/edk/embedder/embedder_unittest.cc View 9 chunks +9 lines, -8 lines 0 comments Download
M third_party/mojo/src/mojo/edk/embedder/platform_channel_pair.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M third_party/mojo/src/mojo/edk/embedder/platform_channel_pair_posix_unittest.cc View 7 chunks +11 lines, -11 lines 0 comments Download
M third_party/mojo/src/mojo/edk/embedder/simple_platform_shared_buffer.cc View 3 chunks +4 lines, -2 lines 0 comments Download
M third_party/mojo/src/mojo/edk/embedder/simple_platform_shared_buffer_posix.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/mojo/src/mojo/edk/embedder/simple_platform_shared_buffer_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/mojo/src/mojo/edk/embedder/simple_platform_support.cc View 2 chunks +3 lines, -1 line 0 comments Download
M third_party/mojo/src/mojo/edk/js/tests/js_to_cpp_tests.cc View 4 chunks +6 lines, -4 lines 0 comments Download
M third_party/mojo/src/mojo/edk/system/channel.cc View 5 chunks +7 lines, -7 lines 0 comments Download
M third_party/mojo/src/mojo/edk/system/channel_endpoint.cc View 4 chunks +6 lines, -4 lines 0 comments Download
M third_party/mojo/src/mojo/edk/system/channel_endpoint_unittest.cc View 2 chunks +3 lines, -1 line 0 comments Download
M third_party/mojo/src/mojo/edk/system/channel_manager.cc View 5 chunks +6 lines, -4 lines 0 comments Download
M third_party/mojo/src/mojo/edk/system/channel_test_base.cc View 2 chunks +3 lines, -1 line 0 comments Download
M third_party/mojo/src/mojo/edk/system/core.cc View 1 chunk +1 line, -1 line 0 comments Download
M third_party/mojo/src/mojo/edk/system/data_pipe.cc View 4 chunks +9 lines, -9 lines 0 comments Download
M third_party/mojo/src/mojo/edk/system/data_pipe_impl.cc View 2 chunks +2 lines, -1 line 0 comments Download
M third_party/mojo/src/mojo/edk/system/endpoint_relayer.cc View 2 chunks +3 lines, -1 line 0 comments Download
M third_party/mojo/src/mojo/edk/system/ipc_support.cc View 4 chunks +6 lines, -6 lines 0 comments Download
M third_party/mojo/src/mojo/edk/system/ipc_support_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/mojo/src/mojo/edk/system/local_data_pipe_impl.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/mojo/src/mojo/edk/system/local_message_pipe_endpoint.cc View 2 chunks +2 lines, -1 line 0 comments Download
M third_party/mojo/src/mojo/edk/system/master_connection_manager.cc View 5 chunks +7 lines, -6 lines 0 comments Download
M third_party/mojo/src/mojo/edk/system/message_in_transit.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M third_party/mojo/src/mojo/edk/system/message_pipe.cc View 3 chunks +4 lines, -2 lines 0 comments Download
M third_party/mojo/src/mojo/edk/system/message_pipe_perftest.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/mojo/src/mojo/edk/system/message_pipe_test_utils.cc View 3 chunks +4 lines, -2 lines 0 comments Download
M third_party/mojo/src/mojo/edk/system/multiprocess_message_pipe_unittest.cc View 6 chunks +10 lines, -10 lines 0 comments Download
M third_party/mojo/src/mojo/edk/system/platform_handle_dispatcher.h View 2 chunks +3 lines, -1 line 0 comments Download
M third_party/mojo/src/mojo/edk/system/platform_handle_dispatcher.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M third_party/mojo/src/mojo/edk/system/platform_handle_dispatcher_unittest.cc View 5 chunks +8 lines, -7 lines 0 comments Download
M third_party/mojo/src/mojo/edk/system/proxy_message_pipe_endpoint.cc View 2 chunks +2 lines, -1 line 0 comments Download
M third_party/mojo/src/mojo/edk/system/raw_channel.cc View 6 chunks +8 lines, -9 lines 0 comments Download
M third_party/mojo/src/mojo/edk/system/raw_channel_posix.cc View 6 chunks +8 lines, -8 lines 0 comments Download
M third_party/mojo/src/mojo/edk/system/raw_channel_unittest.cc View 17 chunks +26 lines, -23 lines 0 comments Download
M third_party/mojo/src/mojo/edk/system/remote_consumer_data_pipe_impl.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M third_party/mojo/src/mojo/edk/system/remote_message_pipe_unittest.cc View 5 chunks +6 lines, -6 lines 0 comments Download
M third_party/mojo/src/mojo/edk/system/remote_producer_data_pipe_impl.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M third_party/mojo/src/mojo/edk/system/slave_connection_manager.cc View 2 chunks +3 lines, -1 line 0 comments Download
M third_party/mojo/src/mojo/edk/system/transport_data.cc View 3 chunks +3 lines, -2 lines 0 comments Download
M third_party/mojo/src/mojo/edk/test/multiprocess_test_helper_unittest.cc View 3 chunks +5 lines, -2 lines 0 comments Download
M third_party/mojo/src/mojo/edk/test/test_utils_posix.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (4 generated)
dcheng
+avi for sanity check / general review +yzshen for owners review
4 years, 12 months ago (2015-12-27 21:48:35 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1545333002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1545333002/1
4 years, 12 months ago (2015-12-27 21:48:52 UTC) #3
Avi (use Gerrit)
lgtm stampity stamp
4 years, 12 months ago (2015-12-27 22:04:58 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 12 months ago (2015-12-27 23:06:30 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1545333002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1545333002/1
4 years, 12 months ago (2015-12-27 23:10:16 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 12 months ago (2015-12-27 23:15:12 UTC) #9
commit-bot: I haz the power
4 years, 12 months ago (2015-12-27 23:16:07 UTC) #11
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/3fdc85f2dbc3e7eed608bebf3e9eaf9b87454807
Cr-Commit-Position: refs/heads/master@{#366942}

Powered by Google App Engine
This is Rietveld 408576698