Issue 15453002: Add thread checker to FileSystemOperationContext to allow setters called only on initialization thr…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 15453002: Add thread checker to FileSystemOperationContext to allow setters called only on initialization thr… (Closed)

Created:
7 years, 7 months ago by kinuko

Modified:
7 years, 7 months ago

Reviewers:
tzik

CC:
chromium-reviews, tzik+watch_chromium.org, kinuko+watch, darin-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Add thread checker to FileSystemOperationContext to allow setters called only on initialization thread Controlling them only by 'friend'-ing doesn't look scalable. BUG=241701 R=tzik@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=201075

Created: 7 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+32 lines, -27 lines)			Patch
M	webkit/fileapi/file_system_operation_context.h	View	5 chunks	+28 lines, -25 lines	0 comments	Download
M	webkit/fileapi/file_system_operation_context.cc	View	1 chunk	+4 lines, -1 line	0 comments	Download
M	webkit/fileapi/local_file_system_operation.cc	View	1 chunk	+0 lines, -1 line	0 comments	Download

Total messages: 3 (0 generated)

kinuko

PTL. I can't think of any other good way to make this safer & not ...

7 years, 7 months ago (2013-05-20 10:46:41 UTC) #1

kinuko

7 years, 7 months ago (2013-05-20 12:00:06 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r201075 (presubmit successful).