content/browser/service_worker/service_worker_navigation_handle_core.cc - Issue 1545243002: Convert Pass()→std::move() in //content/browser

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/service_worker/service_worker_navigation_handle_core.cc

Issue 1545243002: Convert Pass()→std::move() in //content/browser (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/service_worker/service_worker_job_coordinator.cc ('k') | content/browser/service_worker/service_worker_provider_host.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/service_worker/service_worker_navigation_handle_core.cc

diff --git a/content/browser/service_worker/service_worker_navigation_handle_core.cc b/content/browser/service_worker/service_worker_navigation_handle_core.cc

index f1dc1eeffd9a59cc421df1e438528a8d6993a726..8c4791da37453b8632439efad7e247262dffc4ea 100644

--- a/content/browser/service_worker/service_worker_navigation_handle_core.cc

+++ b/content/browser/service_worker/service_worker_navigation_handle_core.cc

@@ -4,6 +4,8 @@

#include "content/browser/service_worker/service_worker_navigation_handle_core.h"

+#include <utility>

#include "base/bind.h"

#include "content/browser/service_worker/service_worker_context_core.h"

#include "content/browser/service_worker/service_worker_context_wrapper.h"

@@ -37,7 +39,7 @@ void ServiceWorkerNavigationHandleCore::DidPreCreateProviderHost(

DCHECK(precreated_host.get());

DCHECK(context_wrapper_->context());

- precreated_host_ = precreated_host.Pass();

+ precreated_host_ = std::move(precreated_host);

context_wrapper_->context()->AddNavigationHandleCore(

precreated_host_->provider_id(), this);

BrowserThread::PostTask(

@@ -57,7 +59,7 @@ ServiceWorkerNavigationHandleCore::RetrievePreCreatedHost() {

DCHECK(context_wrapper_->context());

context_wrapper_->context()->RemoveNavigationHandleCore(

precreated_host_->provider_id());

- return precreated_host_.Pass();

+ return std::move(precreated_host_);

}

} // namespace content